[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.14] Revert wf activity state, still prevent nil ptr #8137

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[1.14] Revert wf activity state, still prevent nil ptr #8137

merged 2 commits into from
Oct 2, 2024

Conversation

cicoyle
Copy link
Contributor
@cicoyle cicoyle commented Sep 24, 2024 •
edited
Loading

Bringing this PR to the release branch. Fix the wf nil ptr & no activity state issue while also adding a few nice to haves for developers

closes this issue

@cicoyle
open new pr based off old
742846b 
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle cicoyle requested review from a team as code owners September 24, 2024 03:31
@cicoyle
Copy link
Contributor Author
cicoyle commented Sep 24, 2024

This change is definitely needed due to the perf tests failing with this error: no activity state found. Please see this test: TestSeriesWorkflowWithMaxVUs that is failing, amongst various other workflow tests that are failing due to that error being returned and not allowing the workflow to continue successfully. Here are additional dapr logs for evidence
perf-workflowsapp-7b7dc69fcf-zpdr8.daprd.log

@cicoyle cicoyle changed the title Revert wf activity state, still prevent nil ptr [1.14] Revert wf activity state, still prevent nil ptr Sep 24, 2024
@cicoyle cicoyle added the autoupdate DaprBot will keep the Pull Request up to date with master branch label Oct 2, 2024
@artursouza artursouza merged commit cc1d412 into dapr:release-1.14 Oct 2, 2024
30 checks passed
@cicoyle cicoyle mentioned this pull request Oct 2, 2024
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshVanL JoshVanL JoshVanL approved these changes

Assignees
No one assigned
Labels
autoupdate DaprBot will keep the Pull Request up to date with master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cicoyle @JoshVanL @artursouza