8000 Adding icon customization for database, schema, table and view by rkgarcia · Pull Request #383 · danvergara/dblab · GitHub
[go: up one dir, main page]
Skip to content

Adding icon customization for database, schema, table and view - #383

Open
rkgarcia wants to merge 1 commit into
mainfrom
custom-icons
Open

Adding icon customization for database, schema, table and view#383
rkgarcia wants to merge 1 commit into
mainfrom
custom-icons

Conversation

@rkgarcia
@rkgarcia rkgarcia commented Oct 31, 2026
Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Sometimes the icons doesnt render fine with emojis.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@rkgarcia rkgarcia linked an issue Oct 31, 2026 that may be closed by this pull request
[FEATURE] Customize icons #381
Open
@rkgarcia
rkgarcia requested a review from danvergara October 31, 2026 19:38
danvergara
danvergara requested changes Nov 1, 2026
View reviewed changes
@danvergara danvergara left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thin I did't like about partial config reads enabled by default, but overall, looks good

Comment thread pkg/config/config.go
}

// GetIcons reads the icons field from the config file.
func GetIcons() map[string]string {
@danvergara danvergara Nov 1, 2026
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this more optional and put it behind a cli flag? I don't want partial config reads enabled by default, see how we manage the keybindings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danvergara danvergara danvergara requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Customize icons

2 participants

@rkgarcia @danvergara
0