8000 Add mssql to the test suite and CI by rkgarcia · Pull Request #382 · danvergara/dblab · GitHub
[go: up one dir, main page]
Skip to content

Add mssql to the test suite and CI - #382

Merged
danvergara merged 4 commits into
mainfrom
add-mssql-test-to-integration-tests
Oct 25, 2026
Merged

Add mssql to the test suite and CI#382
danvergara merged 4 commits into
mainfrom
add-mssql-test-to-integration-tests

Conversation

@rkgarcia
@rkgarcia rkgarcia commented Oct 24, 2026 •
edited by danvergara
Loading 8000
Copy link
Copy Markdown
Collaborator

Add mssql to the test suite and CI

Description

We don't test with SQL Server database.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Running integration tests locally.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@rkgarcia rkgarcia changed the title Adding mssql test with sakila docker image Adding mssql tests with SQL Server sakila docker image Oct 24, 2026
@rkgarcia
rkgarcia requested a review from danvergara October 24, 2026 04:40
@danvergara danvergara changed the title Adding mssql tests with SQL Server sakila docker image Add mssql to the test suite and CI Oct 25, 2026
@danvergara
danvergara merged commit 88dc74e into main Oct 25, 2026
4 checks passed
@danvergara
danvergara deleted the add-mssql-test-to-integration-tests branch October 25, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danvergara danvergara danvergara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rkgarcia @danvergara
0