[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copied_turns in ConversationalTestCase #1035

Conversation

jaime-cespedes-sisniega
Copy link
Contributor

There is a bug at the time of using ConversationalTestCase with more than one turn. Currently only the last turn is added to copied_turns list.

Moving this line inside the for loop (adding each turn to copied_turns) solves the bug.

Copy link
vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evals-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 8:32pm

@penguine-ip
Copy link
Contributor

@jaime-cespedes-sisniega thanks!

@penguine-ip penguine-ip merged commit 0bbe878 into confident-ai:main Sep 26, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants