Repository navigation
Tags
Tags
COMP: Address review feedback (@lassoan) - Make qRestAPI_INSTALL_DEVELOPMENT a proper option() (default OFF), replacing the double-negative if(NOT DEFINED ..._INSTALL_NO_DEVELOPMENT); bump cmake_minimum_required to 3.16.3 so CMP0077 is NEW (option() honors a parent-set value). The deprecated ..._INSTALL_NO_DEVELOPMENT is still honored with a deprecation warning. - Move the *Config.cmake.in templates under CMake/ (gives the directory a reason to exist) and drop the now-pointless CMAKE_MODULE_PATH prepend. - In both config templates, call find_dependency(Qt...) before including the targets file (canonical ordering). - Exclude private *_p.h headers from the development install. - Drop Qt4 support (EOL; not relocatable in the install tree and its find_dependency component list didn't match the linked libraries). - Require the Qt Test component only when BUILD_TESTING is on (Testing/CMakeLists.txt), not as an unconditional dependency. - Use ${PROJECT_NAME}_ spellings consistently.
COMP: Align source headers with the declared Apache 2.0 license Every source file carried a 3D Slicer-style header that deferred the license terms to "Doc/copyright/copyright.txt" or, failing that, to http://www.slicer.org/copyright/copyright.txt. Both pointers are wrong for this project: * Doc/copyright/copyright.txt has never existed in this repository. The headers were copied verbatim from Slicer when the sources were first imported in c6cd6ff (2011-06-11), but the referenced document was never brought along, leaving a dangling reference that instructs the reader to consult a file that is not there. * slicer.org/copyright/copyright.txt describes the Slicer License, a BSD-style license. The project's own license was declared later, in ddc0cfc (2018-01-22, "Add license file"), as the Apache License 2.0 with Copyright (c) 2010 Kitware, Inc. The headers were never updated to match, so the file-level notices and the repository's LICENSE have disagreed ever since. Both licenses are permissive and share the same copyright holder, so this was never a conflict of terms. It was, however, a genuine source of ambiguity: Apache 2.0 carries an explicit patent grant and a NOTICE requirement that the BSD-style license does not, and automated license scanners flag the mismatch between a declared license and file headers that reference a different, unresolvable one. Each header already ended with the "Unless required by applicable law or agreed to in writing..." paragraph, which is the closing half of the Apache 2.0 boilerplate; only the grant clause naming the license was missing. Replace the two dangling lines with that grant clause, taken from the appendix of LICENSE, so each header reads as the complete and standard notice. Per-file copyright years (2010, and 2021 for the Girder sources), the attribution to Jean-Christophe Fillion-Robin, and the NIH grant 3P41RR013218-12S1 acknowledgment are preserved as they were. The edits are confined to the comment blocks; there is no functional change.