Repository navigation
chore(examples): record the type check on tsc 7.1.0-dev.20261104.1 - #196
Conversation
All 732 cases give the verdicts they gave on 7.1.0-dev.20260918.1; only the version line differs.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
ℹ️ No critical issues — two small inconsistencies in the version record.
Reviewed changes
Reviewed the version bump in the driver matrix's type-check record. typecheck/check.ts runs the root install's node_modules/.bin/tsc, and the root pnpm-lock.yaml resolves typescript to 7.1.0-dev.20261104.1, so the regenerated line matches a fresh install.
typecheck/RESULTS.md— the generated header now names7.1.0-dev.20261104.1, and the counts are unchanged (732 cases over 124 client types).README.md— the type check paragraph now names the new tsc.
ℹ️ The top-level RESULTS.md still names the old tsc
lab/driver-matrix/RESULTS.md:229 still says `tsc` Version 7.1.0-dev.20260918.1 and links to typecheck/RESULTS.md for the details, which now names a different version. That line comes from runner.ts reading typecheck/results.json during ./run.sh, so it is accurate as a record of the last full run. But after this PR the two committed records disagree.
Technical details
# Top-level RESULTS.md disagrees with typecheck/RESULTS.md on the tsc version
## Affected sites
- lab/driver-matrix/RESULTS.md:229 — still says `Version 7.1.0-dev.20260918.1`; written by `lab/driver-matrix/runner.ts:287` from `typecheck/results.json`
## Required outcome
- The two committed records name the same tsc, or the difference is intentional and the PR body says so
## Suggested approach (optional)
- Rerun `./run.sh` and commit its `RESULTS.md`, then check it with `compare.ts`. Or, since the verdicts are identical, edit only line 229 to match.claude-opus-5-5 ｜ 𝕏
The README sentence records earlier case counts, so it no longer names a version; the top-level RESULTS.md names the one typecheck/RESULTS.md does.
There was a problem hiding this comment.
✅ No new issues found. Both points from the last review are addressed.
Reviewed changes
Reviewed b1a57cd, which keeps the tsc version in the generated records and takes it out of the narrative.
README.md: the type check paragraph now says "the repository's tsc" with no version. The older counts (552 over 94, 612 over 104) are no longer tied to a tsc that never produced them.RESULTS.md: the type check line now names7.1.0-dev.20261104.1, the same version as thetypecheck/RESULTS.mdit links to. The counts line is unchanged.
One small note: the PR body still says "The README names the new version". After this commit that is no longer true, so you may want to update the body.
claude-opus-5-5 ｜ 𝕏
The driver matrix's type check records the tsc version in
typecheck/RESULTS.md. The file said7.1.0-dev.20260918.1, while the lockfile installs7.1.0-dev.20261104.1, so regenerating it on a fresh install changed the file.Regenerated with the installed tsc. All 732 cases over 124 client types give the same verdicts as before; only the version line differs. The matrix's top-level
RESULTS.mdnames the same version, and the README no longer names one, since its counts are earlier measurements.