Repository navigation
feat(cli): rename compile back to analyze, as a function and a command - #195
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
I reviewed both commits: renaming the type-defs API and command from compile back to analyze, and the separate fix to the order in which src/cli.ts sets up its signal handlers.
- Public API rename:
compile()/CompileInputbecomeanalyze()/AnalyzeInputacrosssrc/index.ts,src/build-time.ts(BuildTime) andsrc/tooling.ts.Toolinginsrc/tooling-loader.tsisBuildTime & {…}, so it picks up the new name without an edit. - Module and test renames:
src/compile.tsbecomessrc/analyze-api.ts, which keeps it apart fromsrc/analyze.ts, the cache and sessions module. The bundle test now checks thatsrc/analyze-api.tsstays out of the root's browser bundle. - Binary command:
reylo compilebecomesreylo analyzeinengine/cli/src/main.rsandengine/cli/src/analyze.rs, including the usage text, the error prefixes and thereylo generateremoval message. - Internal
compilekept: the placeholder rewriter insrc/execute.tskeeps its name.src/index.tsdrops thecompileQueryalias, since the public name no longer clashes with it. - Docs, skill and spec strings: the
#analyzeanchor, the FAQ link and the link inSKILL.mdall match. The schema's description, the generatedspec/index.ts8000 and the published0.1.0.jsonchanged together. - Signal handlers before
spawn: the forwarders go in before the child starts. Signal handlers only run on a later turn of the event loop, so by thenchildhas its value from the synchronousspawncall.
I grepped the whole repository at head: no stale reylo compile, compile.ts, compile.rs, CompileInput or #compile reference remains.
claude-opus-5-5 ｜ 𝕏
A signal sent once the binary could answer, before the handlers were in, ended the command and left the binary running.
Compile reads as producing a build artifact, and this returns a statement's types.
colinhacks
force-pushed
the
analyze-name
branch
from
November 6, 2026 06:21
bc6c780 to
c6a9258
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the type defs call back to
analyze:analyze()fromreyloandreylo analyze. "Compile" reads as producing a build artifact, and this call returns a statement's types. Neither name has been published, so there is no alias.What changes
compile(),CompileInputanalyze(),AnalyzeInputreylo compilereylo analyzesrc/compile.tssrc/analyze-api.ts, sincesrc/analyze.tsis the cache and sessionstests/compile.test.tstests/analyze-api.test.tstests/compile-cli.test.tstests/analyze-cli.test.tsengine/cli/src/compile.rsengine/cli/src/analyze.rs#compile#analyzeThe internal
compileinsrc/execute.ts, which rewrites placeholders, keeps its name.A fix found on the way
reyloinstalled its signal handlers just after starting the binary. A signal sent once the binary could answer, but before the handlers were in, ended the command and left the binary running. The handlers now go in first. This is its own commit.The test for it failed under load: 3 of 120 parallel runs before the fix, 0 of 360 after, with the machine's load average above 240.
Checked
nub run typecheck, andnub run testwith both test databases: 365 passed, 0 skipped.cargo build --workspace --all-targetswith no warning, and the tests ofreyloandreylo-engine-core.nub run buildinsite/, with the#analyzeanchor and the FAQ's link to it in the output.