Repository navigation
ci(release): install the engine packages' drivers before the build - #86
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
I reviewed the one change to the release workflow's stage job, which installs the engine packages' own dependencies before nub run build.
- Per-package installs before the build:
nub install --frozen-lockfilenow runs inpackages/postgresandpackages/mysql. This givesscripts/build.tsthe drivers it bundles intodist/<db>/describe.js(postgres3.4.9 andmysql23.24.4, each a devDependency with its ownpnpm-lock.yaml). The steps are the same astest.ymlL60-65, flag and order included.
<
8000
/ul>
claude-opus-5-5 ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release's
stagejob rannub installat the root only. Since #68,nub run buildbundles each engine package's describer with its driver, which is a development dependency ofpackages/postgres(postgres) andpackages/mysql(mysql2), so the build in that job fails:The job now installs both packages before the build, as
test.ymlalready does.Verified locally in a fresh worktree: with the root install alone,
nub run buildfails as above; with the two package installs added, it writesdist/postgresanddist/mysqlwith theirdescribe.js.actionlintpasses on the workflow.