Repository navigation
fix(mysql): name mariadb among the clients run takes - #82
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
I reviewed the update to the MySQL entry of the accepted-clients message, and the test added for it.
accepted.mysqlnames mariadb: theTypeErrorfromunsupported()now listsquery(text, values)on mariadb's pool or connection, from its promise or callback API. This matches how.run()detects mariadb atsrc/execute.ts:342(batch()plusquery(), checked beforeexecute()).- Test for the message:
tests/execute.test.tsnow passes a method-less object to a MySQL statement and checks that the refusal includes the mariadb wording.
claude-opus-5-5 ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
.run()refuses a client for a MySQL statement, its message lists the clients it takes. That list left out mariadb's pool and connection, which.run()takes throughquery(text, values), from mariadb's promise or callback API, and which the driver matrix measures on three versions. The list now names it, and a test checks the message.