Repository navigation
feat: let .reylo.yaml turn the sqlcommenter comment off - #60
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
ℹ️ No critical issues. Two rough edges are worth a look.
Reviewed changes
This review covers the new sqlcommenter key in .reylo.yaml, from the engine's parser through the build step, the type check and the docs.
- Project file key:
sqlcommenter: Option<bool>inengine/core/src/config.rs, resolved totrueunless the file saysfalse(src/project.ts). All three artifacts are rebuilt. - Build step and type check:
src/loader.ts,src/mapper.tsandsite/scripts/capture-types.tsskipwithSqlcommenterwhen the key is off. The hover's note comes from the newsqlNote(commented). - Invalidation: the flag is added to the
Session.forkey and the mapper'sconfigIdentity, so a running process builds new imports with the new setting. - Docs and tests: a new
### sqlcommentersection in Configuration and a link from Usage. The new tests cover the default and the off case, plus switching it back on in the same process.
claude-opus-5-5 ｜ 𝕏
colinhacks
force-pushed
the
sqlcommenter-key
branch
2 times, most recently
from
October 23, 2026 19:01
63ddb65 to
c3acea0
Compare
Contributor
There was a problem hiding this comment.
✅ No new issues found. Both points from the last review are fixed.
Reviewed changes
Since the last Pullfrog review, the build step now tells the bundlers which project files a module's text depends on. The engine artifacts were also rebuilt over main.
- Bundler invalidation:
sqlModulenow returnswatched, which is the project'swatchedfiles that exist on disk: the project file and the.envfiles. The Vite, webpack and esbuild adapters register these beside the.reylo/entry, so changingsqlcommenterrebuilds modules that were already built.tests/analyze.test.tschecks whatwatchedholds. Toolingtype:sqlModule's return type and doc comment insrc/engine-package.tsnow includewatched.src/register-worker.tsreads onlycode, so it is unaffected.- Dead export: removed
SQL_NOTE. Thesrc/index.tscomment now namessqlNote. - Artifacts: rebuilt all three
engine.wasmovera8537a6.
claude-opus-5-5 ｜ 𝕏
colinhacks
force-pushed
the
sqlcommenter-key
branch
from
October 23, 2026 19:33
c3acea0 to
531232e
Compare
sqlcommenter in the project file, true when absent, switches the comment that names each statement's file; sqlcommenter: false leaves it off.
colinhacks
force-pushed
the
sqlcommenter-key
branch
from
October 23, 2026 20:09
531232e to
a64dafa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every statement a build step writes ends with a comment naming its
.sqlfile, in sqlcommenter's format. This addssqlcommenterto the project file to switch it. It is on when absent, andsqlcommenter: falseleaves the comment off:sqlcommenterin the engine's project-file parser (engine/core/src/config.rs), which refuses unknown keys, so all three engine artifacts are rebuilt in oneengine/build.shrun.src/project.tsresolves it totrueunless the file saysfalse.sql, the declaration'ssqlliteral and the hover's note all leave the comment out (sqlNoteinsrc/doc-comment.ts).Session.forkeys its sessions on the setting, so the next build after the project file changes uses a new session.sqlcommentersubsection, and a link from Usage's.sql.Test plan
cargo test -p reylo-engine-core config;engine/build.sh(all three artifacts)nub run typecheck;nub run testagainst throwaway Postgres 18 and MySQL 8.4, with the labs linked: 221 pass, 0 skippedsqlcommenter: false, the built module'ssql, a run on SQLite, the declaration'ssqlliteral and its note; then, in the same process, the project file turned back on gives the commenttests/project.test.ts: on by default, off withsqlcommenter: falsesite:nub run capture(no change: the docs keep the default) andnub run build; the subsection checked at desktop and phone widths