8000 chore: remove schema files until their design is settled by colinhacks · Pull Request #6 · colinhacks/reylo · GitHub
[go: up one dir, main page]

Skip to content

chore: remove schema files until their design is settled - #6

Merged
colinhacks merged 2 commits into
mainfrom
revert-schema-files
Oct 22, 2026
Merged

colinhacks merged 2 commits into
mainfrom
revert-schema-files

Conversation

@colinhacks
Copy link
8000 Copy Markdown
Owner

Removes the schema key of .reylo.yaml, which typed queries from SQL files (a schema dump or a directory of migrations) with no database, while its design is reconsidered: running the project's own migration command against a throwaway database may replace reading migration files directly.

  • Reverts b0c1c3c, f5f8878, 81a77fa and 9015424: the engine's schema key, src/schema-files.ts, its tests and fixture, the PGlite dev dependency and optional peer, and the docs.
  • Rebuilds the three engine.wasm artifacts from the reverted source, since a9ab0dd rebuilt them after the key was added.
  • Keeps the docs-kit sync (6421a0b), which only strips a heading's custom id from the Markdown export.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 16:28
@vercel
vercel Bot commented Oct 22, 2026 •
Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
reylo Ready Ready Preview Oct 22, 2026 5:02pm UTC

Request Review

@pullfrog
pullfrog Bot commented Oct 22, 2026 •
Copy link
Copy Markdown
Contributor

No configured credential can serve this run. Your Claude Pro/Max subscription was rejected. Sign in again by running pullfrog auth claude in a terminal.

The providers' responses
CLAUDE_CODE_OAUTH_TOKEN: 401: OAuth access token has been revoked.

Pick another model →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog | Using claude-opus-5-5

Copilot AI left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@pullfrog pullfrog Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

The branch had no earlier Pullfrog review, so this run covers the new merge commit and the full revert.

  • Merged main cleanly: git show --cc 75ea55d shows no conflict resolutions. #8's MySQL VECTOR changes come in unchanged.
  • Rebuilt packages/mysql/engine.wasm: the new artifact contains #8's to_vector( rewrite. It no longer has the schema key's "a path, or a list of paths" deserializer message, which main's artifact still has. The Postgres and SQLite artifacts lack that message as well.
  • Removed the schema key end to end: this covers config.rs, analyze.ts, cli.ts, mapper.ts, project.ts and the docs. Nothing in src/ or tests/ still refers to schema-files.ts. The rewritten include/exclude filter in generate behaves the same as before for projects that set neither key.
  • Dropped @electric-sql/pglite from the root package: tests/representation.test.ts still loads PGlite, but it resolves it through lab/drivers/node_modules, so the removal doesn't break it.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@colinhacks
colinhacks merged commit 54db692 into main Oct 22, 2026
4 checks passed
@colinhacks
colinhacks deleted the revert-schema-files branch October 22, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0