[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues for Brazilian Portuguese white-paper #911

Merged
merged 3 commits into from
May 21, 2022

Conversation

jralmaraz
Copy link
Contributor

Slowly trying to address the issues on PT-BR white-paper version from CI:

https://github.com/cncf/tag-security/runs/6508469351?check_suite_focus=true

@jralmaraz
Copy link
Contributor Author

Hi @lumjjb - am I allowed to add brazilian portuguese to https://github.com/cncf/tag-security/blob/main/ci/spelling-config.json#L3 ? Or how is multiple languages planned to be handled in CI's spell check stage ?

Thanks!

lumjjb
lumjjb previously approved these changes May 20, 2022
Copy link
Contributor
@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!! Thanks @jralmaraz !!! Going to run enable running the workflow!

@lumjjb lumjjb dismissed their stale review May 20, 2022 16:02

workflow wasn't run yet

@lumjjb
Copy link
Contributor
lumjjb commented May 20, 2022

I think it'll be fine if we just do <!-- cspell:disable -->, that should work for now!

@jralmaraz
Copy link
Contributor Author

thanks @lumjjb ! Let's see the next CI run :)

Copy link
Contributor
@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 All green! Thanks again @jralmaraz ! Welcome to the community!

@lumjjb lumjjb merged commit efb183d into cncf:main May 21, 2022
Michael-Susu12138 pushed a commit to Michael-Susu12138/tag-security that referenced this pull request Dec 12, 2023
* resolves cncf#909

* resolving link issues

* cspell disable and link fix

Co-authored-by: Almaraz <jalmaraz@deloitte.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants