[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use upload-artifact@v4 for C3 e2e tests #7111

Merged
merged 3 commits into from
Nov 12, 2024
Merged

chore: use upload-artifact@v4 for C3 e2e tests #7111

merged 3 commits into from
Nov 12, 2024

Conversation

petebacondarwin
Copy link
Contributor
@petebacondarwin petebacondarwin commented Oct 28, 2024 •
edited
Loading

Fixes #0000

I note that no C3 e2e log files appear be getting uploaded in CI tests; maybe this will fix that.
E.g. https://github.com/cloudflare/workers-sdk/actions/runs/11521770262/job/32076164707#step:5:230

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: CI change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: C3 change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: CI change

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8841ba9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Oct 28, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11552225904/npm-package-wrangler-7111

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7111/npm-package-wrangler-7111

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11552225904/npm-package-wrangler-7111 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11552225904/npm-package-create-cloudflare-7111 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11552225904/npm-package-cloudflare-kv-asset-handler-7111
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11552225904/npm-package-miniflare-7111
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11552225904/npm-package-cloudflare-pages-shared-7111
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11552225904/npm-package-cloudflare-vitest-pool-workers-7111
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11552225904/npm-package-cloudflare-workers-editor-shared-7111
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11552225904/npm-package-cloudflare-workers-shared-7111
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11552225904/npm-package-cloudflare-workflows-shared-7111

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.83.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin force-pushed the upload-artifact-fix branch 3 times, most recently from bfef8c5 to ab01f71 Compare October 28, 2024 08:38
@petebacondarwin petebacondarwin marked this pull request as ready for review October 28, 2024 14:54
@petebacondarwin petebacondarwin requested review from a team as code owners October 28, 2024 14:54
@petebacondarwin
Copy link
Contributor Author

This PR also starts running C3 e2e tests on all PRs since they are not pretty fast. I am worried it might start flaking so something to consider when reviewing this.

petebacondarwin
petebacondarwin commented Oct 28, 2024
View reviewed changes
packages/create-cloudflare/turbo.json
@@ -26,7 +26,8 @@
"E2E_EXPERIMENTAL",
"TEST_PM"
],
"dependsOn": ["build"]
"dependsOn": ["build"],
"outputs": [".e2e-logs", ".e2e-logs-experimental"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the key to the logs being available even if turbo decides to use the cache hit.

petebacondarwin
petebacondarwin commented Oct 28, 2024
View reviewed changes
.github/actions/run-c3-e2e/action.yml
path: packages/create-cloudflare/.e2e-logs${{inputs.experimental && '-experimental' || ''}}
include-hidden-files: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this was needed but since we have put the logs under a dot-prefixed directory, it felt useful

@andyjessop
Copy link
Contributor

Great! This will be a really useful addition.

@andyjessop andyjessop merged commit 6c714a4 into main Nov 12, 2024
30 checks passed
@andyjessop andyjessop deleted the upload-artifact-fix branch November 12, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyjessop andyjessop andyjessop approved these changes

Assignees
No one assigned
Labels
no-changeset-required
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petebacondarwin @andyjessop