Repository navigation
Conversation
- created a weather microservice for port 8088
- added classification data
- created a testing thrift client
- created Kubernetes .yaml scripts
|
So I can finally connect a face with the name. A pleasure to make your acquaintance. Will we be cooperating or is development going to stay an isolated thing? Update: |
| import urllib | ||
|
|
||
| port = 8088 | ||
| owm_api_key = "362537b891e6df03a316e82565fe4df3" |
There was a problem hiding this comment.
ew Magic Numbers, can you move this to a config and put in the README that it needs to be set or something? Should be a "secret"
|
|
||
| try: | ||
| # weather from Weather Underground | ||
| f = urllib2.urlopen('http://api.wunderground.com/api/%s/conditions/q/%s.json' % (wu_api_key, url_location) ) |
| print "From Weather Underground: %s" % result | ||
| else: | ||
| # weather from Open Weather Map | ||
| f = urllib2.urlopen('http://api.openweathermap.org/data/2.5/weather?q=%s&appid=%s&units=imperial&type=like' % (url_location, owm_api_key)) |
| import json | ||
| import urllib | ||
|
|
||
| port = 8088 |
There was a problem hiding this comment.
we really need to rethink how all the ports are set, it's super messy to have them nested deep into the code. then you need to worry about setting them correctly within the CMD center as well
|
This generally looks good, I need to test it out but I like the content. |
|
We should probably merge #163 before this right? I'd want to be able to test this with your tmux script (since that makes it actually easier to test :P) |
| def create(self, LUCID, spec): | ||
| return | ||
|
|
||
| """ |
There was a problem hiding this comment.
these docstrings should be inside the function header, check how we do it internally
|
Yes, I completely agree. Let me work on the changes for the tmux PR first
and then add changes based on that merge within this PR.
…---
Saijel Mokashi
https://clinc.com
On Mon, Apr 17, 2017 at 8:36 AM, Johann Hauswald ***@***.***> wrote:
We should probably merge #163
<#163> before this right? I'd
want to be able to test this with your tmux script (since that makes it
actually easier to test :P)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#166 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZQku7Lrf_TuXPqmt16F97_m6RowKU1mks5rw1yzgaJpZM4M99uF>
.
|
|
Why is this code mixing urllib2 and urllib? [There should be no reason to use urllib2 - all methods you call should be available in urllib.] And do you want me to keep commenting or shall I keep to myself? |