ipam/crd: Add new flag for configuring custom resource update rate #23017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
reviewed
Jan 10, 2023
027318d
to
1669d48
Compare
|
@gandro Thanks for the comment! Please take another look. |
gandro
approved these changes
Jan 12, 2023
1669d48
to
d1af6e4
Compare
|
/test |
In crd ipam modes, the current agent side ciliumnode update rate is hardcoded as 15 seconds, which might be too big in burst pod creation cases. e.g. when a large number of pods are scheduled to a single node, let's say 25 pods and the `pre-allocate` is set to 5, a maximum of 5 IPs can be allocated every 15 seconds (update of used IPs are rate limited), which causes some pods to wait too long. This commit adds a new agent flag `ipam-cilium-node-update-rate` to configure the ciliumnode custom resource update rate. Signed-off-by: Jaff Cheng <jaff.cheng.sh@gmail.com>
d1af6e4
to
8fea8f1
Compare
|
/test |
tommyp1ckles
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In crd ipam modes, the current agent side custom resource update rate is hardcoded as 15 seconds, which might be too big in burst pod creation cases. e.g. when a large number of pods are scheduled to a single node, let's say 25 pods and the
pre-allocateis set to 5, a maximum of 5 IPs can be allocated every 15 seconds (update of used IPs are rate limited), which causes some pods to wait too long.This commit adds a new agent flag
ipam-cilium-node-update-rateto configure the ciliumnode custom resource update rate.Signed-off-by: Jaff Cheng jaff.cheng.sh@gmail.com