-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trees and lists #264
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
* chore(examples): go mod tidy * feat(tree): add rounded corner enumerator
Hey @testinfected we're still doing some usability tests on the API to decide if the developer experience is where we want it to be before release. No ETA yet, but the functionality is there, just want to make sure it's easy to use before publishing. We don't want to have to break the API in the future, so now's the time to get it all sorted :) |
@bashbunni i just wonder something 🤔 There are today two ways to use a list as a user input in the charmbracelet ecosystem:
Do you plan something on this subject ? It could be amazing to use the same list either in a user input or output way ❤️ |
hey @nervo ! Ideally, we'll use this new component on both of these once this is merged :) |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Docs:
Unexpected Behaviour: Styling Qs:
|
We should also improve godoc on |
can you share an example? |
@caarlos0 🤦♀️ totally didn't include the code to repro did I? LOL The broken one (using l := list.New().Items(
"S",
list.New().Items([]string{"vim", "doom emacs"}),
list.New().Item("I like fuzzy socks"),
)
fmt.Println(l) The one used in examples: l2 := list.New().
Item("S").
Item(list.New().Items([]string{"vim", "doom emacs"})).
Item(list.New().Item("I like fuzzy socks"))
fmt.Println(l2) which doesn't include the extra bullets, even though technically these two solutions should have the same output |
fixed @bashbunni |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
* docs(godoc): add overview * docs(godoc): include examples in godoc * docs(godoc): fix roman numerals example * docs(godoc): fix tree examples * docs(godoc): attempt to fix list Enumerator examples
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Worked on top of @maaslalani trees and lists implementations, fixed some bugs, refactor some stuff, added a couple of possibilities (namely, sublists (as trees)), etc.
Its a big PR, but it if it makes it better, it closes this 4 other PRs:
closes #242
closes #240
closes #243
closes #263
Some examples: