[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gum choose --ordered not working anymore #687

Open
MrLuje opened this issue Oct 15, 2024 · 1 comment · May be fixed by #722
Open

gum choose --ordered not working anymore #687

MrLuje opened this issue Oct 15, 2024 · 1 comment · May be fixed by #722
Assignees
Labels
bug Something isn't working cmd/choose

Comments

@MrLuje
Copy link
MrLuje commented Oct 15, 2024

Describe the bug

gum choose --ordered used to work but not anymore

To Reproduce
Steps to reproduce the behavior:

  1. run the following script
#!/usr/bin/env bash

touch values.yaml
touch values-dev.yaml
touch values-dev-2.yaml

echo $(gum choose $(ls values*.yaml) --ordered --no-limit)
  1. result is always values-dev-2.yaml values-dev.yaml values.yaml whatever the order

Expected behavior
Per gum completion : "Maintain the order of the selected options"

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows WSL2
  • Version 0.14.5

Additional context
I looked at the source code, there is no reference anymore to Ordered flag, apart from its definition:

Ordered bool `help:"Maintain the order of the selected options" env:"GUM_CHOOSE_ORDERED"`

The code handling the order disappeared with this commit : 44906e2

@lomboboo
Copy link

I can confirm - have the same issue. Using gum choose --ordered doesn't work for me.

caarlos0 added a commit that referenced this issue Nov 18, 2024
closes #687

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
caarlos0 added a commit that referenced this issue Nov 18, 2024
closes #687

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 linked a pull request Nov 18, 2024 that will close this issue
@caarlos0 caarlos0 added the bug Something isn't working label Nov 18, 2024
@caarlos0 caarlos0 self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmd/choose
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants