[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gum choose v0.14.0: timeout no longer working #565

Closed
daviehh opened this issue May 4, 2024 · 1 comment · Fixed by #618
Closed

gum choose v0.14.0: timeout no longer working #565

daviehh opened this issue May 4, 2024 · 1 comment · Fixed by #618

Comments

@daviehh
Copy link
daviehh commented May 4, 2024 •
edited
Loading

Describe the bug
gum choose --selected="foo" --timeout=3s "a" "b" "foo" "d"
timeout no longer working

To Reproduce
Steps to reproduce the behavior:

  1. gum choose --selected="foo" --timeout=3s "a" "b" "foo" "d"
  2. No progress

Expected behavior
timeout after 3s

Desktop (please complete the following information):

  • OS: macos 14.4.1

Incidentally

gum/choose/options.go

Line 27 in 4222e59

Timeout time.Duration `help:"Timeout until choose returns selected element" default:"0" env:"GUM_CCHOOSE_TIMEOUT"` // including timeout command options [Timeout,...]

typo for GUM_CCHOOSE_TIMEOUT?
@MrOggy85
Copy link

I think this change broke the timeout: #522
It seems like the timeout functionality was not implemented when using the new framework @maaslalani

csandeep added a commit that referenced this issue Jul 11, 2024
@csandeep
Added timeout option to choose
73244b6 
ref: #565
@csandeep csandeep mentioned this issue Jul 11, 2024
Merged
maaslalani pushed a commit that referenced this issue Jul 12, 2024
@csandeep
Added timeout option to choose and other patches (maybe) (#618)
1d07efd 
* Added timeout option to choose

ref: #565

* Update 'charmbracelet/huh' dependency to main

* removed the `replace ..` huh line

* tidy'd the dependency tree!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added timeout option to choose and other patches (maybe) charmbracelet/gum
2 participants
@MrOggy85 @daviehh