[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: race changing ignoreSignals #791

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix: race changing ignoreSignals #791

merged 2 commits into from
Nov 7, 2023

Conversation

caarlos0
Copy link
Member
@caarlos0 caarlos0 commented Aug 1, 2023

multiple goroutines can try to ReleaseTerminal (and/or RestoreTerminal) at the same time, causing a data race.

@caarlos0 caarlos0 added the bug Something isn't working label Aug 1, 2023
@caarlos0 caarlos0 self-assigned this Aug 1, 2023
aymanbagabas
aymanbagabas reviewed Aug 1, 2023
View reviewed changes
tea.go Outdated Show resolved Hide resolved
@caarlos0 caarlos0 merged commit 5984e69 into master Nov 7, 2023
18 checks passed
@caarlos0 caarlos0 deleted the race branch November 7, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas aymanbagabas approved these changes

@muesli muesli Awaiting requested review from muesli

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caarlos0 @aymanbagabas