Repository navigation
feat(notifications): add per-task incident policies - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sequence Diagram
sequenceDiagram participant Runner participant Policy as Notification Policy participant DB as SQLite participant Channel as Feishu or SMTP Runner->>Policy: Report task result Policy->>DB: Read task state and delivery counters DB-->>Policy: Return incident state and limits alt Message allowed Policy->>DB: Reserve delivery slot and persist state Policy->>Channel: Send notification Channel-->>Policy: Return delivery result Policy->>DB: Persist sent or suppressed state else Duplicate or rate limited Policy->>DB: Persist suppressed count end Policy-->>Runner: Keep the original task exit codeVerification
python3 -m unittest discover -s tests -v(53 tests passed)node --check web/app.jsnode tests/frontend.cjsgit diff --checkNotes