[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change opencollective to contributors-img #779

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

FantasqueX
Copy link
Contributor

Details are described in #481

change opencollective to contributors-img in README-zh_CN.md
change opencollective to contributors-img in README.md
@github-actions
Copy link

📝 Docs preview for commit fc0d42e at: https://608119d8a823d67771ce7ed7--modest-austin-48be4a.netlify.app

@iromise
Copy link
Member
iromise commented Apr 22, 2021

@FantasqueX I haven't taken a close look at the contributors-img. Is there some big difference between opencollective and contributors-img?

@FantasqueX
Copy link
Contributor Author

@FantasqueX I haven't taken a close look at the contributors-img. Is there some big difference between opencollective and contributors-img?

Since I don't have a repository with more than 100 stars, I can't use open collective. But from my observation of issues of open collective opencollective/opencollective-api#1164 and README.md of oi-wiki, the images generated by opencollective are outdated. And I can't find the sync frequency from the doc.

As for contributors-img explains caveats in the author's blog:

  • A repo having too many contributors takes a long time to generate an image.
  • For each repository, images are generated once in a day and it will be cached for later requests.

Here is an example of the author's repo https://github.com/angular/angular-ja , it works well.

I think the differences are as follows:

  1. Sync frequency.
  2. Open collective offers a lot of parameters while contributos-img doesn't.
  3. Contributer-img provides larger width for each individual avatar.

@iromise
Copy link
Member
iromise commented Apr 22, 2021

@FantasqueX It seems good, but I find that the figure generated is not beautiful as well as opencollective. Besides, it is too large.

@FantasqueX
Copy link
Contributor Author
FantasqueX commented Apr 23, 2021

@iromise Surely, that's quite a problem :(

@arttnba3
Copy link
Member
arttnba3 commented Oct 3, 2024

@iromise It's okay that the picture is not beautiful enough, as the correct result does mean to be more important than a look. We can just change to contributors-img temporarily, and find the one with better look in the future when we have spare time to do so.

@arttnba3
Copy link
Member
arttnba3 commented Oct 3, 2024

Hi FantasqueX,

Thanks for your contributions! This plugin dose work well and I'm going to merge your pull request. This is just a notification message, and you don't need to take further actions to respond.

If you have any questions, or if you have further concerns, please feel free to contact us.

Best regards,
arttnba3
CTF-wiki team
04/10/2024

@arttnba3 arttnba3 merged commit 673879c into ctf-wiki:master Oct 3, 2024
@arttnba3 arttnba3 mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants