Repository navigation
tighten package requirements for HTFA Docker image - #30
Merged
Merged
Conversation
jeremymanning
self-requested a review
March 13, 2021 23:22
jeremymanning
approved these changes
Mar 13, 2021
Collaborator
There was a problem hiding this comment.
lgtm-- i reviewed this with @paxtonfitzpatrick while he was working on it. @manojneuro do you want to merge this or should i?
Collaborator
|
to give some additional background: i had my students for this class go through the HTFA tutorial and some of them ran into trouble running the notebook due to changes in the packages @paxtonfitzpatrick mentioned above. this pull request pins the version numbers of some additional packages to provide more "future proofing" for the docker image and notebook associated with the HTFA tutorial. |
paxtonfitzpatrick
force-pushed
the
master
branch
from
March 14, 2021 00:48
086ecb8 to
fd62dfc
Compare
old version referenced a sklearn module that's been renamed, was throwing an error when importing nltools
paxtonfitzpatrick
force-pushed
the
master
branch
from
March 14, 2021 00:58
fd62dfc to
f0a2a43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be appl
2E8A
ied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent updates to some third-party modules introduced a few bugs in the HTFA notebook. Pinned various MPI & plotting packages to ensure a working combination of dependency versions are installed.