Repository navigation
Burn in is removed so that the size of the signal and noise volumes are the same - #542
Merged
Merged
Conversation
lcnature
approved these changes
Jul 6, 2024
Contributor
There was a problem hiding this comment.
I think this should fix the bug.
mihaic
approved these changes
Jul 8, 2024
mihaic
enabled auto-merge
July 8, 2024 16:15
mihaic
added this pull request to the merge queue
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example currently generates a signal volume that has a burn in it, but that is not added to the noise volume. That creates volumes of different sizes. We have removed the burn in to simplify things.