Repository navigation
Introducing non-thermal EDFs - #9
Open
pedronaethe wants to merge 19 commits into
Open
pedronaethe wants to merge 19 commits into
pedronaethe wants to merge 19 commits into
Conversation
…uns but haven't been tested - kappa seems much slower than the other distributions - no tests were performed so far
…phere model. Changed makefile to recompile everything only when necessary
- I have to update the CI to account for this
- Still have to fix the CI - I have to implement mixed thermal + nonthermal components
- I still have to add dNe/dgamma_y for the non thermal processes
- I still haven't tested it at all against igrmonty.
…is version, there's probably a bug somewhere
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for non-thermal electron distribution functions (EDFs), including κ, power-law, and variable κ models.
To support this, a few parts of the code had to be updated:
The results agree well with igrmonty. In igrmonty, the electron distribution is sampled numerically, while kmonty uses a semi-analytical approach. Both options are now implemented here and seem to have similar runtimes.
One issue that still needs to be understood: when using VARIABLE_KAPPA with GRMHD data, gpumonty shows sharp, likely non-physical bumps in the scattering-dominated part of the spectrum:
I haven’t tracked down the cause yet. My current suspicion is the electron sampling, but that’s still under investigation.