Repository navigation
Handles failed param decryption before writing output - #828
Open
jstaylor11 wants to merge 1 commit into
Open
jstaylor11 wants to merge 1 commit into
jstaylor11 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two small problems that have the potentially difficult to track down problems.
First, when an encrypted-record decryption fails, setparamvalue() is called, which references undefined mdata, masking the failure with UnboundLocalError.
The setparam CLI also opens the .patched output before validation, which can create an empty file or truncate an existing output.
This change:
Validation:
python -B -m unittest discover -s tests -p test_oneplus_param.py -v
All three tests pass.
Related to #815. This addresses failure handling only; it does not
resolve the underlying serial-derived-key compatibility issue.