8000 chore(css_parser): remove properties by denbezrukov · Pull Request #1877 · biomejs/biome · GitHub
[go: up one dir, main page]

Skip to content

chore(css_parser): remove properties - #1877

Merged
denbezrukov merged 1 commit into
mainfrom
chore/remove-properties
Feb 20, 2024
Merged

denbezrukov merged 1 commit into
mainfrom
chore/remove-properties

Conversation

@denbezrukov
Copy link
Copy Markdown
Contributor

Summary

#268 (comment)

Test Plan

cargo test

@github-actions github-actions Bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-CSS Language: CSS and super languages labels Feb 20, 2024
@netlify
netlify Bot commented Feb 20, 2024 •
Copy link
Copy Markdown

✅ Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 6cd305e
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65d51972dcacba0007221f45

@github-actions
Copy link
Copy Markdown
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

@codspeed
codspeed Bot commented Feb 20, 2024
Copy link
Copy Markdown
Contributor

CodSpeed Performance Report

Merging #1877 will degrade performances by 13.42%

Comparing chore/remove-properties (6cd305e) with main (7f131f6)

Summary

❌ 1 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main chore/remove-properties Change
❌ big5-added.json[cached] 2.2 ms 2.6 ms -13.42%

@denbezrukov
denbezrukov merged commit 69f9031 into main Feb 20, 2024
@denbezrukov
denbezrukov deleted the chore/remove-properties branch February 20, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0