8000 feat(js-api): expose grit search to js-api by dyc3 · Pull Request #8912 · biomejs/biome · GitHub
[go: up one dir, main page]

Skip to content

feat(js-api): expose grit search to js-api - #8912

Merged
dyc3 merged 1 commit into
mainfrom
dyc3/expose-search-to-js-api
Oct 8, 2026
Merged

dyc3 merged 1 commit into
mainfrom
dyc3/expose-search-to-js-api

Conversation

@dyc3
@dyc3 dyc3 commented Jan 29, 2026 •
Copy link
Copy Markdown
Contributor

Summary

This exposes the functions from the previous PR in the js-api package.

generated by glm-4.7, fixed up by opus 5.5

Test Plan

unit tests

Docs

@changeset-bot
changeset-bot Bot commented Jan 29, 2026 •
Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 07767a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@biomejs/js-api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dyc3 commented Jan 29, 2026 •
Copy link
Copy Markdown
Contributor Author

@dyc3
dyc3 force-pushed the dyc3/expose-search-to-js-api branch from ae0a95f to 96937b5 Compare January 29, 2026 21:09
@dyc3
dyc3 force-pushed the dyc3/expose-search-to-wasm branch from 62effcf to ef02264 Compare January 29, 2026 21:10
Base automatically changed from dyc3/expose-search-to-wasm to main January 30, 2026 07:17
@dyc3
dyc3 marked this pull request as ready for review January 30, 2026 21:20
@coderabbitai
coderabbitai Bot commented Jan 30, 2026 •
Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: biomejs/biome/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 9524a087-960e-441b-b806-1057ea495327
📥 Commits

Reviewing files that changed from the base of the PR and between 96937b5 and 07767a1.

📒 Files selected for processing (4)
  • .changeset/grit-search-bindings.md
  • packages/@biomejs/js-api/src/common.ts
  • packages/@biomejs/js-api/src/wasm.ts
  • packages/@biomejs/js-api/tests/nodejs.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/grit-search-bindings.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.


Walkthrough

The JavaScript API now exposes GritQL pattern parsing, content search and pattern release. Search results provide match ranges as UTF-8 byte offsets. Tests cover JavaScript and CSS searches, byte-offset conversion, invalid patterns and searches with dropped patterns.

Suggested reviewers: ematipico

Priority: ➖ Normal

Change: Feature

Merge Risk: ⚪ Minimal · up to 07767

The search API’s returned match ranges align with its documented JavaScript behavior. No identified issue prevents merging after normal checks.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarises the main change: exposing GritQL search through the js-api package.
Description check ✅ Passed The description is related to the changeset. It explains the API exposure and identifies unit tests as the test plan.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ematipico ematipico left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new feature, so it should go to the next branch, with a minor changeset

@ematipico
ematipico marked this pull request as draft April 12, 2026 10:33
@dyc3
dyc3 commented Oct 7, 2026
Copy link
Copy Markdown
Contributor Author

Might as well dust this off for the minor

@dyc3
dyc3 force-pushed the dyc3/expose-search-to-js-api branch from 96937b5 to 07767a1 Compare October 8, 2026 03:42
@dyc3
dyc3 marked this pull request as ready for review October 8, 2026 12:47
@dyc3 dyc3 added this to the Biome v2.6 milestone Oct 8, 2026
@dyc3
dyc3 commented Oct 8, 2026
Copy link
Copy Markdown
Contributor Author

@biome-cookie review

@biome-cookie biome-cookie left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Review complete. No findings.

Review Status

  • Scope: packages/@biomejs/js-api/src/common.ts, packages/@biomejs/js-api/src/wasm.ts, packages/@biomejs/js-api/tests/nodejs.test.ts, .changeset/grit-search-bindings.md

  • Branch target: main

  • Changeset: .changeset/grit-search-bindings.md

  • Brief: Expose GritQL parse/search/drop methods in @biomejs/js-api

  • Validation: No verified suggested changes were published; findings may be based on static review.

  • Fetch: 07767a1

@dyc3
dyc3 merged commit e9785d8 into main Oct 8, 2026
10 checks passed
@dyc3
dyc3 deleted the dyc3/expose-search-to-js-api branch October 8, 2026 14:24
@github-actions github-actions Bot mentioned this pull request Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0