Repository navigation
feat(js-api): expose grit search to js-api - #8912
Conversation
🦋 Changeset detectedLatest commit: 07767a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ae0a95f to
96937b5
Compare
62effcf to
ef02264
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. WalkthroughThe JavaScript API now exposes GritQL pattern parsing, content search and pattern release. Search results provide match ranges as UTF-8 byte offsets. Tests cover JavaScript and CSS searches, byte-offset conversion, invalid patterns and searches with dropped patterns. Suggested reviewers: Priority: ➖ Normal Change: Feature Merge Risk: ⚪ Minimal · up to The search API’s returned match ranges align with its documented JavaScript behavior. No identified issue prevents merging after normal checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
This is a new feature, so it should go to the next branch, with a minor changeset
|
Might as well dust this off for the minor |
96937b5 to
07767a1
Compare
|
@biome-cookie review |
There was a problem hiding this comment.
Review Summary
Review complete. No findings.
Review Status
-
Scope: packages/@biomejs/js-api/src/common.ts, packages/@biomejs/js-api/src/wasm.ts, packages/@biomejs/js-api/tests/nodejs.test.ts, .changeset/grit-search-bindings.md
-
Branch target: main
-
Changeset: .changeset/grit-search-bindings.md
-
Brief: Expose GritQL parse/search/drop methods in @biomejs/js-api
-
Validation: No verified suggested changes were published; findings may be based on static review.
-
Fetch: 07767a1

Summary
This exposes the functions from the previous PR in the
js-apipackage.generated by glm-4.7, fixed up by opus 5.5
Test Plan
unit tests
Docs