8000 feat(html): add various helpers to html syntax nodes by dyc3 · Pull Request #8804 · biomejs/biome · GitHub
[go: up one dir, main page]
Skip to content

feat(html): add various helpers to html syntax nodes - #8804

Merged
ematipico merged 1 commit into
mainfrom
dyc3/html-element-helpers
Jan 19, 2026
Merged

feat(html): add various helpers to html syntax nodes#8804
ematipico merged 1 commit into
mainfrom
dyc3/html-element-helpers

Conversation

@dyc3
@dyc3 dyc3 commented Jan 19, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Summary

Adds some useful helpers to HTML syntax nodes, mostly to make it easier to extract the tag name without a bunch of code.

These helpers will be used later in this stack of PRs.

Test Plan

CI should be green

Docs

@changeset-bot
changeset-bot Bot commented Jan 19, 2026
Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9465485

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dyc3 Graphite App
dyc3 commented Jan 19, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 19, 2026
Merged
Merged
@github-actions github-actions Bot added A-Parser Area: parser L-HTML Language: HTML and super languages labels Jan 19, 2026
@dyc3
dyc3 requested review from a team January 19, 2026 13:33
@dyc3
dyc3 marked this pull request as ready for review January 19, 2026 13:33
@coderabbitai
coderabbitai Bot commented Jan 19, 2026
Copy link
Copy Markdown
Contributor

Walkthrough

This pull request extends the HTML syntax API with tag-name accessors and element introspection utilities. New tag_name() methods are added to HtmlSelfClosingElement, HtmlOpeningElement, and HtmlElement to retrieve element names. The AnyHtmlElement enum receives updated and new methods: name() is refactored to delegate to the corresponding tag_name() variants, closing_r_angle_token() provides access to closing angle tokens for standard HTML elements, and Svelte-specific utilities is_svelte_block() and as_svelte_block() enable type checking and conversion for Svelte blocks. Corresponding imports are updated to support these additions.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding helper methods to HTML syntax nodes for easier tag name extraction and other utilities.
Description check ✅ Passed The description clearly explains the motivation (simplifying tag name extraction), mentions these helpers will be used in subsequent PRs, and references CI validation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

ematipico
ematipico approved these changes Jan 19, 2026
View reviewed changes
@ematipico ematipico left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ematipico
ematipico merged commit cf51ad3 into main Jan 19, 2026
15 checks passed
@ematipico
ematipico deleted the dyc3/html-element-helpers branch January 19, 2026 14:05
@coderabbitai coderabbitai Bot mentioned this pull request Jan 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-Parser Area: parser L-HTML Language: HTML and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dyc3 @ematipico
0