8000 release: v1.9.4 by Conaclos · Pull Request #4320 · biomejs/biome · GitHub
[go: up one dir, main page]
Skip to content

release: v1.9.4 - #4320

Merged
Conaclos merged 2 commits into
mainfrom
release/1.9.4
Oct 17, 2024
Merged

release: v1.9.4#4320
Conaclos merged 2 commits into
mainfrom
release/1.9.4

Conversation

@Conaclos
@Conaclos Conaclos commented Oct 17, 2024 •
edited
Loading
Copy link
Copy Markdown
Member

Summary

  1. Add a changelog entry for every Pull Request that lacks one.
    You can filter merged PRs that don't update the changelog.
    Read our guidelines for editing the changelog.

  2. Based on the changelog, determine which version number to use.
    See our versioning guide for more details.

  3. Rename Unreleased to <version> (iso-date) in the changelog.

  4. Update version in Biome's package.json if applicable.

  5. Update to the same version in all crates if you publish crates. (Cargo.toml and crates/**/Cargo.toml)

  6. Linter rules have a version metadata directly defined in their implementation.
    This field is set to next for newly created rules.
    This field must be updated to the new version.

  7. Update the website with the new version number:
    BIOME_VERSION=<version> just gen-web.
    This will also copy the configuration schema in the right place.

  8. Once the PR is merged, the CI will trigger the Release: * workflows. Once these workflows finish compiling the final artefact, they need to be approved manually.

@github-actions github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS and super languages A-Changelog Area: changelog labels Oct 17, 2024
@Conaclos Conaclos changed the title chore(release): v1.9.4 release: v1.9.4 Oct 17, 2024
@Conaclos
Conaclos requested review from a team October 17, 2024 14:15
@ematipico
ematipico commented Oct 17, 2024
Copy link
Copy Markdown
Member

@Conaclos The PR #4301 wasn't supposed to be merged, because it's a new feature. We should revert it, and merge it once we finished with bug fixes.

@codspeed
codspeed Bot commented Oct 17, 2024 •
edited
Loading
Copy link
Copy Markdown
Contributor

CodSpeed Performance Report

Merging #4320 will not alter performance

Comparing release/1.9.4 (9d71150) with main (1303f99)

Summary

✅ 101 untouched benchmarks

@github-actions github-actions Bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools labels Oct 17, 2024
@Conaclos
Conaclos commented Oct 17, 2024
Copy link
Copy Markdown
Member Author

The PR #4301 wasn't supposed to be merged, because it's a new feature. We should revert it, and merge it once we finished with bug fixes.

You are right. I reverted the change in the PR. I think we can merge it today :)

@github-actions
github-actions Bot commented Oct 17, 2024
Copy link
Copy Markdown
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48420 48420 0
Passed 47212 47228 ✅ ⏫ +16
Failed 1208 1192 ✅ ⏬ -16
Panics 0 0 0
Coverage 97.51% 97.54% +0.03%
🎉 Fixed (16): 
test/built-ins/AsyncDisposableStack/prototype/defer/length.js
test/built-ins/AsyncDisposableStack/prototype/defer/name.js
test/built-ins/AsyncDisposableStack/prototype/defer/not-a-constructor.js
test/built-ins/AsyncDisposableStack/prototype/defer/prop-desc.js
test/built-ins/AsyncDisposableStack/prototype/defer/this-does-not-have-internal-asyncdisposablestate-throws.js
test/built-ins/AsyncDisposableStack/prototype/defer/this-not-object-throws.js
test/built-ins/DisposableStack/prototype/defer/length.js
test/built-ins/DisposableStack/prototype/defer/name.js
test/built-ins/DisposableStack/prototype/defer/not-a-constructor.js
test/built-ins/DisposableStack/prototype/defer/prop-desc.js
test/built-ins/DisposableStack/prototype/defer/this-does-not-have-internal-disposablestate-throws.js
test/built-ins/DisposableStack/prototype/defer/this-not-object-throws.js
test/staging/explicit-resource-management/async-disposable-stack-adopt-and-defer-not-callable.js
test/staging/explicit-resource-management/async-disposable-stack-defer-on-disposed-stack.js
test/staging/explicit-resource-management/async-disposable-stack-defer.js
test/staging/explicit-resource-management/disposable-stack-adopt-and-defer.js

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6578 6578 0
Passed 2204 2204 0
Failed 4374 4374 0
Panics 0 0 0
Coverage 33.51% 33.51% 0.00%

ts/babel

Test result main count This PR count Difference
Total 680 680 0
Passed 607 607 0
Failed 73 73 0
Panics 0 0 0
Coverage 89.26% 89.26% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18489 18489 0
Passed 14154 14153 ❌ ⏬ -1
Failed 4335 4336 ❌ ⏫ +1
Panics 0 0 0
Coverage 76.55% 76.55% -0.01%
🔥 Regression (2): 
compiler/bluebirdStaticThis.ts
compiler/underscoreTest1.ts
🎉 Fixed (1): 
compiler/funduleUsedAcrossFileBoundary.ts

@Conaclos Conaclos mentioned this pull request Oct 17, 2024
Merged
@Conaclos
Conaclos merged commit fa93a14 into main Oct 17, 2024
@Conaclos
Conaclos deleted the release/1.9.4 branch October 17, 2024 17:24
@Conaclos Conaclos mentioned this pull request Oct 17, 2024
Merged
Conaclos added a commit that referenced this pull request Oct 18, 2024
@Conaclos
release: v1.9.4 (#4320)
a2815f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-Changelog Area: changelog A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS and super languages L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Conaclos @ematipico
0