8000 Add install script for setting up csvdiff. Fixes #16 by kishaningithub · Pull Request #17 · aswinkarthik/csvdiff · GitHub
[go: up one dir, main page]

Skip to content

Add install script for setting up csvdiff. Fixes #16 - #17

Merged
aswinkarthik merged 3 commits into
aswinkarthik:masterfrom
kishaningithub:install_script
Oct 29, 2018
Merged

aswinkarthik merged 3 commits into
aswinkarthik:masterfrom
kishaningithub:install_script

Conversation

@kishaningithub
Copy link
Copy Markdown
Contributor

Add install script that detects machine's platform and downloads the respective platform binaries from github releases

Fixes #16

@codecov-io
codecov-io commented Oct 26, 2018 •
Copy link
Copy Markdown

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #17   +/-   ##
======================================
  Coverage    71.5%   71.5%           
======================================
  Files           7       7           
  Lines         193     193           
======================================
  Hits          138     138           
  Misses         54      54           
  Partials        1       1
Impacted Files Coverage Δ
cmd/root.go 16.07% <ø> (ø) ⬆️
cmd/formatter.go 84.61% <ø> (ø) ⬆️
cmd/config.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83dd3da...aee6015. Read the comment docs.

@aswinkarthik aswinkarthik left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few places where my repo is refrenced as aswinkarthik93. I have renamed it to aswinkarthik. Could you make those changes as well?

Comment thread README.md Outdated
yum install https://github.com/aswinkarthik93/csvdiff/releases/download/v1.0.0/csvdiff_1.0.0_linux_64-bit.rpm
```
# binary will be $GOPATH/bin/csvdiff
curl -sfL https://raw.githubusercontent.com/aswinkarthik93/csvdiff/master/install.sh | sh -s -- -b $GOPATH/bin
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename aswinkarthik93 to aswinkarthik. My repo is aswinkarthik

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do it 👍

@kishaningithub
Copy link
Copy Markdown
Contributor Author

Have completed the rename from aswinkarthik93 to aswinkarthik in the entire repo

@aswinkarthik
aswinkarthik merged commit b94cc7e into aswinkarthik:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0