Repository navigation
Introduce apply syntax for event listeners - #402
Merged
Merged
Conversation
kubukoz
marked this pull request as ready for review
October 1, 2024 22:45
Collaborator
Author
I think this is about a static forwarder to this: object EventProp:
@inline private[html] def apply[F[_], E](key: String, f: Any => E): EventProp[F, E] =
new EventProp(key, _.map(f))I would assume we don't care about Java calling us so it's safe. @armanbilge please take 8000 a look boss |
Owner
|
While I agree it's safe, I have a couple concerns:
|
Owner
Bug maybe. A workaround is to use |
Collaborator
Author
|
Makes sense. Added targetName, seems to work fine (locally) without the exclusion. |
armanbilge
reviewed
Oct 7, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #223. Closes #202. Closes #400.