8000 dramatically simplify `ProductZipper` by arainko · Pull Request #130 · arainko/ducktape · GitHub
[go: up one dir, main page]

Skip to content

dramatically simplify ProductZipper - #130

Merged
arainko merged 2 commits into
series/0.2.xfrom
simplify-product-zipper
Feb 28, 2024
Merged

arainko merged 2 commits into
series/0.2.xfrom
simplify-product-zipper

Conversation

@arainko
@arainko arainko commented Feb 27, 2024
Copy link
Copy Markdown
Owner

Change the mechanism of ProductZipper to produce tuple accessors instead of pattern matches

Left(
"Invalid Talk.Name" ::
"Invalid Talk.ElevatorPitch" ::
"Invalid Presenter.Bio" ::
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new encoding results in the errors being reported in the inverse order - I might want to come back to this and make it so it keeps the order the same

@arainko
arainko force-pushed the simplify-product-zipper branch from 26835a2 to 4bc4c34 Compare February 28, 2024 17:53
@arainko
arainko merged commit 93aeebf into series/0.2.x Feb 28, 2024
@arainko
arainko deleted the simplify-product-zipper branch March 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0