Repository navigation
dramatically simplify ProductZipper - #130
Merged
Merged
Conversation
arainko
commented
8000
Feb 27, 2024
| Left( | ||
| "Invalid Talk.Name" :: | ||
| "Invalid Talk.ElevatorPitch" :: | ||
| "Invalid Presenter.Bio" :: |
Owner
Author
There was a problem hiding this comment.
The new encoding results in the errors being reported in the inverse order - I might want to come back to this and make it so it keeps the order the same
arainko
force-pushed
the
simplify-product-zipper
branch
from
February 28, 2024 17:53
26835a2 to
4bc4c34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the mechanism of
ProductZipperto produce tuple accessors instead of pattern matches