Repository navigation
[0.2.x] Fallible transformers - #122
Merged
Merged
Conversation
…g stuff (not really tho)
arainko
force-pushed
the
fallible-transformers-interpreters
branch
from
February 24, 2024 10:42
013bde3 to
88ae3dd
Compare
arainko
force-pushed
the
fallible-transformers-interpreters
branch
from
February 24, 2024 11:25
88ae3dd to
92caec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full impl of fallible transformers.
There are some issues uncovered when compiling with
-Xcheck-macros, namely:AccumulatingandFailFasttransformations report bad owners inside lambdas of non-fallible sub-transformations (eg. ihen transforming betweenOptions,Collections, etc.) - for the time being-Xcheck-macroshas been disabled to be pragmatic and actually deliver the feature set.elementpath element withintoVia(but only during direct transformations, transforming withTransformer.defineworks in those cases as a workaround ()Case.fallible*