[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get REST API JWT From Authorization Bearer #6611

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Get REST API JWT From Authorization Bearer #6611

merged 5 commits into from
Sep 30, 2024

Conversation

lastpeony
Copy link
Contributor

@lastpeony lastpeony changed the title Get API JWT From Authorization Bearer Get REST API JWT From Authorization Bearer Aug 23, 2024
@sonarcloud SonarCloud
Copy link
sonarcloud bot commented Aug 26, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mekya
mekya requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor
@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lastpeony ,

Thank you for the development.

I need you to change the code.

  • There is one header at a time. "Authorizaiton" or "Bearer"
  • It should be backward compatible to parse the "Authorization" header
  • If there is no "Authorization", it'll check the "Bearer" header or vice-versa

Cheers
Oguz

src/main/java/io/antmedia/filter/JWTFilter.java Show resolved Hide resolved
mekya
mekya approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor
@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to merge. I remember somethings wrong. It's my mistake

src/main/java/io/antmedia/filter/JWTFilter.java Show resolved Hide resolved
@mekya mekya merged commit 25fe09a into master Sep 30, 2024
9 checks passed
@mekya mekya deleted the restJwtBearer branch September 30, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekya mekya mekya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lastpeony @mekya @burak-58