Repository navigation
Improve documentation with paragraph about selection of container images to use with Podman - #4687
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Podman inventory documentation now states that selected container images must include Python for many builtin Ansible tasks to run. ChangesPodman documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to This documentation-only change adds guidance about container image requirements and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
@rgaiacs can you please push verified commits? |
|
Hi @shvenkat-rh, sorry my ignorance. What is "verified commits"? I did push a signed commit, see 0b25896. |
Please refer to this https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification |
f39ce11 to
e32e12d
Compare
Signed-off-by: Raniere Gaia Costa da Silva <Raniere.CostadaSilva@gesis.org>
e32e12d to
cc65674
Compare
|
Hi @shvenkat-rh, Thanks for the link. My existing GPG key had expired. I renew it and re-signed the commit. It now has the "verified" badge displayed on GitHub. The GitHub Action "verify PR label action" is failing. Is this because the PR does not mention a GitHub issue? |
|
Good to merge |
I was studying the "Using podman containers example and I had issues when I try to replace the container image used in the example,
ghcr.io/ansible/community-ansible-dev-tools:latest, with another one.I was getting a failure when running the module
ansible.builtin.wait_for_connectionwith the messagetimed out waiting for ping module test: 'ping'that was not very helpful. After some investigation, I discover the problem. The container images that I was trying did not have Python. This pull request improves the example with a reminder to future readers.More details of what I was experimenting in https://github.com/rgaiacs/ansible-molecule-mwe-native-configuration
This is my first pull request. Because it only adds a minor change to the documentation, I did not sign it. I'm happy to amend the commit with a signature if it is required to be merged.
Summary by CodeRabbit