Repository navigation
fix: validate subcommand name before dynamic import - #4620
Merged
Merged
Conversation
RinZ27
force-pushed
the
fix-unintended-module-loading
branch
from
March 4, 2026 06:36
1cbfed1 to
540ae7f
Compare
RinZ27
force-pushed
the
fix-unintended-module-loading
branch
from
March 4, 2026 07:05
540ae7f to
77d2b5e
Compare
RinZ27
force-pushed
the
fix-unintended-module-loading
branch
from
March 4, 2026 07:23
77d2b5e to
4e78cd0
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation for subcommand names in
execute_subcommandensures that only alphanumeric characters and underscores are processed. While checking the command execution flow, I noticed thatimport_modulewas receiving values directly from the scenario configuration 10000 without sanitization. This change prevents potential unintended module loading attempts through special characters or path traversal sequences in the subcommand string.Existing tests for command execution remain unchanged, and I added a new test case to verify that invalid subcommand names are correctly rejected with a
MoleculeError. Verified the changes locally withruffto ensure compliance with the project's linting standards.