8000 fix: correct Emscripten pthread macro name by dajiaohuang · Pull Request #35 · andrewrk/SDL · GitHub
[go: up one dir, main page]

Skip to content

fix: correct Emscripten pthread macro name - #35

Open
dajiaohuang wants to merge 1 commit into
andrewrk:mainfrom
dajiaohuang:fix/emscripten-pthread-macro-name
Open

dajiaohuang wants to merge 1 commit into
andrewrk:mainfrom
dajiaohuang:fix/emscripten-pthread-macro-name

Conversation

@dajiaohuang
Copy link
Copy Markdown

Summary

  • Remove the trailing space from the __EMSCRIPTEN_PTHREADS__ name passed to addCMacro, so the Emscripten build uses a valid macro identifier.

Validation

  • A static check of all eight addCMacro names found the malformed name before the change and no invalid identifiers afterward.
  • git diff --check / commit whitespace check passed.
  • The SDL build and CI were not run: the assigned boundary permits only synthetic build/config fixtures, and this environment has no Zig compiler. No SDL sources were compiled or runtime/device features used.

@jayschwa
Copy link
Copy Markdown

This repo is deprecated and replaced with the SDL2 branch at https://github.com/allyourcodebase/SDL/tree/SDL2. Please send your pull request there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0