8000 fix(pty): kill all PTYs on will-quit to prevent MSVC assertion crash by schroldgames · Pull Request #51 · amirlehmam/wmux · GitHub
[go: up one dir, main page]
Skip to content

fix(pty): kill all PTYs on will-quit to prevent MSVC assertion crash #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amirlehmam merged 1 commit into from
Jun 20, 2026
Merged

fix(pty): kill all PTYs on will-quit to prevent MSVC assertion crash #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,10 @@ app.on('before-quit', () => {
});

app.on('will-quit', () => {
// Kill all PTYs before anything else tears down. Without this, node-pty's
// libuv async handles (batons) are still pending when the process exits,
// triggering the "Assertion failed: remove_pty_baton" MSVC runtime error.
ptyManager.killAll();
pipeServer.stop();
cdpProxy.stop();
portScanner.stop();
Expand Down
0