Repository navigation
Fix stale agent rows in the sidebar - #435
Merged
Merged
Conversation
strayge
marked this pull request as ready for review
November 4, 2026 02:45
A roster member whose state is `unknown` has made no claim, so the sidebar row must not pin it to "reports no state" while fresh hook or observer activity shows it running a tool. Fresh activity (same 5 s window as before) now reads as working with that tool label. Membership stays roster-gated, so retained history still cannot bring a released agent back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its only writer hard-coded it to false once idle claims moved to the shared agent roster, so it could no longer affect any status chain. Remove it from StatusTextInputs and mergedAgentSignals, move its tests onto the roster idle count, and rewrite the hookActivity comments in App.tsx that still described entries kept forever to tell idle from a plain shell. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
amirlehmam
force-pushed
the
feat/sidebar-agent-roster
branch
from
November 4, 2026 10:59
5b1c87c to
b72ac2a
Compare
Owner
|
Thanks, this fixes the ghost rows: agent presence now comes from the shared roster, and released agents no longer come back from old hook history. 18 of your tests fail if the src change is reverted, so it's well covered. Before merging I added two commits:
Merging; it ships in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sidebar keeps showing an agent as idle after it exits because retained hook or observer history establishes its presence independently of the shared agent roster. Identified agents that report no state also incorrectly appear idle.
Changes
Testing