Repository navigation
Inherit the active terminal’s shell for splits and new tabs - #422
Merged
Merged
Conversation
strayge
marked this pull request as ready for review
November 2, 2026 00:37
splitNode is shared with CLI, agent-browser and pipe splits, which type startup commands; inheriting there could type them into an ssh or WSL shell. The shell is now an opt-in argument passed only by the keyboard and tab-bar split actions. A PTY started with no spec no longer reports its resolved executable as launchShell, and resolvedShell stays display only, so new tabs never pin a versioned Store PowerShell path (amirlehmam#334). launchShell is view state for the session snapshot ring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks @strayge, merged and shipping in 2.55.0. I pushed one commit on top before merging:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Splitting a terminal or opening a new tab uses the workspace/default shell instead of the active terminal’s shell.
For example, splitting a WSL terminal can unexpectedly open PowerShell.
Changes
Limitations
Inheritance follows only the shell launched by wmux.
Manually running
wslorsshinside PowerShell does not change the inherited shell.Testing
npm run typecheck: passed.git diff --check: passed.