[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphEditor] Node: Check if unexposed ListAttributes contain links #2578

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cbentejac
Copy link
Contributor

Description

If unexposed attributes (ie. attributes that are located in the lower side of a node, and hidden by default) are connected, they are meant to remain visible even if the lower part of that node is hidden.

This was working fine for any attribute that was not a ListAttribute, as the check was made on whether the attribute's value was a link to another attribute. For ListAttributes, whose value is actually a list of values, this was not working as nested links were not checked.

Instead of relying on the isLink property, we now use isLinkNested: for regular attributes, this is equivalent to using isLink, but for ListAttributes, the full list of values will be checked.

If unexposed attributes (ie. attributes that are located in the lower
side of a node, and hidden by default) are connected, they are meant
to remain visible even if the lower part of that node is hidden.

This was working fine for any attribute that was not a `ListAttribute`,
as the check was made on whether the attribute's value was a link to
another attribute. For `ListAttributes`, whose value is actually a list
of values, this was not working as nested links were not checked.

Instead of relying on the `isLink` property, we now use `isLinkNested`:
for regular attributes, this is equivalent to using `isLink`, but for
`ListAttributes`, the full list of values will be checked.
@cbentejac cbentejac added this to the Meshroom 2024.1.0 milestone Oct 23, 2024
@cbentejac cbentejac self-assigned this Oct 23, 2024
@cbentejac cbentejac linked an issue Oct 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Keyframe selection inputs
1 participant