Repository navigation
fix(inkless:ai): update vale config - #823
Conversation
| # License headers | ||
| BlockIgnores = (?s)(Copyright \(C\).*?If not\, see), (?s)(Licensed to the Apache Software Foundation.*?limitations under the License\.) | ||
|
|
||
| [*.sql] |
There was a problem hiding this comment.
The regex checks only standalone -- comments. It silently skips trailing comments and /* ... */ comments. It can also lint valid SQL beginning with - as prose.
We might extract SQL comments with a comment-aware mechanism that handles standalone, trailing, and block comments without interpreting SQL expressions as comments but I'm also aware that the fix can get complicated, so I can accept a single solution if it's unreasonably complex.
There was a problem hiding this comment.
Fair enough, I didn't like the workaround required to get it working, but makes sense to have it. This commit makes our vale wrapper lint sql files as lua, which has the same comment syntax: a7e4ced
There was a problem hiding this comment.
Ok, that's fair enough, let's see how it works.
| tokens: | ||
| - '\b[a-z][a-z0-9]*(?:_[a-z0-9]+)+\b' | ||
| - '\b[A-Z][A-Z0-9]*(?:_[A-Z0-9]+)+\b' | ||
| - '\b[a-z_][a-z0-9_]*(?:\.[a-z_][a-z0-9_]*)+\b' |
There was a problem hiding this comment.
The dotted-name regex flags aiven.io and both halves of foo.bar@example.com. These warnings fail the AI-attributed CI check. We should exclude email addresses and hostnames, or narrow the pattern to identifier contexts.
There was a problem hiding this comment.
Addressed ✅ it's noteworthy that anything in `backticks` is not linted by vale
) The 0.51 entry records the switch phase gates, the bounded consolidation prune, and their config, metric, and schema changes. The generator draft missed the new default of `inkless.consolidation.cleanup.interval.ms` and the broker and controller metrics that `metrics.rst` doesn't cover. Its `PostgresControlPlane` delta is documentation catch-up for metrics that 0.50 already registered. The session logs record the cherry-pick of #823 through #854 to `inkless-4.1`, `inkless-4.2`, and `inkless-4.3`, the conflict resolutions, and the release-branch build fixes. ## Testing - `make vale` reports no alerts. Assisted-by: Claude Opus 5.5
This PR makes the following updates to
vale:sqlfilesAGENTS.md:Google.Passivefromsuggestiontowarning