Repository navigation
feat(inkless:metrics): add inkless-tag and kafka-version to app-info [KC-595] - #821
Merged
Merged
Conversation
jeqo
force-pushed
the
jeqo/inkless-tag-metric
branch
from
October 12, 2026 10:06
7d9bb23 to
62a9e69
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Untagged Git checkouts expose a commit hash instead of the documented unknown value.
3 open findings
What changed in this PR
Adds Inkless release and upstream Kafka version metadata to application metrics and JMX.
Changes:
- Adds
inkless-tagandkafka-versiongauges and MBean attributes. - Derives the upstream Kafka version from the Inkless version.
- Adds documentation and tests.
| File | Description |
|---|---|
AppInfoParser.java |
Registers and exposes the new version metadata. |
AppInfoParserTest.java |
Tests metric lifecycle and version derivation. |
FEATURES.md |
Documents the new gauges and MBean attributes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jeqo
force-pushed
the
jeqo/inkless-tag-metric
branch
from
October 12, 2026 10:34
62a9e69 to
30200bc
Compare
jeqo
force-pushed
the
jeqo/inkless-tag-metric
branch
from
October 12, 2026 10:51
30200bc to
c4446a9
Compare
Operators can read the Inkless release tag of a running broker or client from the app-info metric group and the AppInfo MBean, next to version and commit-id. The inkless-tag value is unknown when the build has no Inkless tag. The version metric carries the full Inkless version, such as 4.3.1-inkless. Dashboards and upgrade checks that compare against upstream Kafka need the plain 4.3.1. AppInfo also exposes kafka-version, derived by removing the -inkless qualifier, and keeps any -SNAPSHOT suffix. Assisted-by: Claude Sonnet 5.5
jeqo
force-pushed
the
jeqo/inkless-tag-metric
branch
from
October 12, 2026 11:04
c4446a9 to
7c61837
Compare
jeqo
marked this pull request as ready for review
October 12, 2026 11:10
gqmelo
approved these changes
Oct 15, 2026
jeqo
added a commit
that referenced
this pull request
Oct 19, 2026
…821) Operators can read the Inkless release tag of a running broker or client from the app-info metric group and the AppInfo MBean, next to version and commit-id. The inkless-tag value is unknown when the build has no Inkless tag. The version metric carries the full Inkless version, such as 4.3.1-inkless. Dashboards and upgrade checks that compare against upstream Kafka need the plain 4.3.1. AppInfo also exposes kafka-version, derived by removing the -inkless qualifier, and keeps any -SNAPSHOT suffix. Assisted-by: Claude Sonnet 5.5
jeqo
added a commit
that referenced
this pull request
Oct 19, 2026
…821) Operators can read the Inkless release tag of a running broker or client from the app-info metric group and the AppInfo MBean, next to version and commit-id. The inkless-tag value is unknown when the build has no Inkless tag. The version metric carries the full Inkless version, such as 4.3.1-inkless. Dashboards and upgrade checks that compare against upstream Kafka need the plain 4.3.1. AppInfo also exposes kafka-version, derived by removing the -inkless qualifier, and keeps any -SNAPSHOT suffix. Assisted-by: Claude Sonnet 5.5
jeqo
added a commit
that referenced
this pull request
Oct 19, 2026
…821) Operators can read the Inkless release tag of a running broker or client from the app-info metric group and the AppInfo MBean, next to version and commit-id. The inkless-tag value is unknown when the build has no Inkless tag. The version metric carries the full Inkless version, such as 4.3.1-inkless. Dashboards and upgrade checks that compare against upstream Kafka need the plain 4.3.1. AppInfo also exposes kafka-version, derived by removing the -inkless qualifier, and keeps any -SNAPSHOT suffix. Assisted-by: Claude Sonnet 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operators can read the Inkless release tag of a running broker or client from the
app-infometric group and theAppInfoMBean, next toversionandcommit-id.inkless-tag: thegit describeoutput of the nearestinkless-*tag, such asinkless-4.2.1-0.45. A build can set the value with-PinklessTag, which takes precedence over git. Without-PinklessTag, the value isunknownwhen the build has no git checkout or git can't describe it (git is unavailable or there is noHEAD). On a checkout with no matchinginkless-*tag, the value is the abbreviated commit hash, becausedetermineInklessTag()usesgit describe --always. That behavior is unchanged by this PR.kafka-version: the upstream Kafka version, derived by removing the-inklessqualifier fromversion, such as4.3.1for4.3.1-inkless. A-SNAPSHOTsuffix is kept. Dashboards and upgrade checks that compare against upstream Kafka need the plain version.Both are also available as the
InklessTagandKafkaVersionattributes of theAppInfoMBean. The new metrics are documented indocs/inkless/FEATURES.md.