Repository navigation
fix(inkless:consolidation): exclude consolidation from ConsumerLag [KC-546] - #816
Merged
Merged
Conversation
…C-546] ConsolidationFetcherThread inherits AbstractFetcherThread lag tracking, so its diskless-to-local backlog was registered under FetcherLagMetrics.ConsumerLag alongside classic replica lag. Dashboards and scrapers that sum that metric then treat consolidation backlog as replica catch-up. Skip only the ConsumerLag JMX gauge for consolidation fetchers while keeping in-memory fetcherLagStats for MaxLag. ConsolidationLocalLag remains the external first-hop lag signal. Test plan - :core:test AbstractFetcherThreadTest, ReplicaFetcherThreadTest, ConsolidationFetcherThreadTest - spotlessCheck; vale on the added prose Assisted-by: Composer
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
An added comment violates the mandatory identifier-formatting rules for Inkless-owned prose.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Excludes consolidation backlog from Kafka’s generic ConsumerLag metric while retaining internal MaxLag tracking.
Changes:
- Makes
ConsumerLaggauge registration configurable. - Disables the gauge for consolidation fetchers.
- Adds tests, documentation, and ownership metadata.
| File | Description |
|---|---|
INKLESS_OWNERSHIP |
Marks AbstractFetcherThread.scala as interleaved. |
docs/inkless/DISKLESS_CONSOLIDATION.md |
Documents consolidation lag metrics. |
ConsolidationFetcherThreadTest.scala |
Tests gauge suppression and lag tracking. |
AbstractFetcherThread.scala |
Adds conditional gauge registration. |
ConsolidationFetcherThread.scala |
Disables ConsumerLag registration. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Updated comments for clarity and consistency. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
giuseppelillo
approved these changes
Oct 2, 2026
jeqo
pushed a commit
that referenced
this pull request
Oct 19, 2026
…C-546] (#816) * fix(inkless:consolidation): exclude consolidation from ConsumerLag [KC-546] ConsolidationFetcherThread inherits AbstractFetcherThread lag tracking, so its diskless-to-local backlog was registered under FetcherLagMetrics.ConsumerLag alongside classic replica lag. Dashboards and scrapers that sum that metric then treat consolidation backlog as replica catch-up. Skip only the ConsumerLag JMX gauge for consolidation fetchers while keeping in-memory fetcherLagStats for MaxLag. ConsolidationLocalLag remains the external first-hop lag signal. Test plan - :core:test AbstractFetcherThreadTest, ReplicaFetcherThreadTest, ConsolidationFetcherThreadTest - spotlessCheck; vale on the added prose Assisted-by: Composer * Refine comments in ConsolidationFetcherThread Updated comments for clarity and consistency. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jeqo
pushed a commit
that referenced
this pull request
Oct 19, 2026
…C-546] (#816) * fix(inkless:consolidation): exclude consolidation from ConsumerLag [KC-546] ConsolidationFetcherThread inherits AbstractFetcherThread lag tracking, so its diskless-to-local backlog was registered under FetcherLagMetrics.ConsumerLag alongside classic replica lag. Dashboards and scrapers that sum that metric then treat consolidation backlog as replica catch-up. Skip only the ConsumerLag JMX gauge for consolidation fetchers while keeping in-memory fetcherLagStats for MaxLag. ConsolidationLocalLag remains the external first-hop lag signal. Test plan - :core:test AbstractFetcherThreadTest, ReplicaFetcherThreadTest, ConsolidationFetcherThreadTest - spotlessCheck; vale on the added prose Assisted-by: Composer * Refine comments in ConsolidationFetcherThread Updated comments for clarity and consistency. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jeqo
pushed a commit
that referenced
this pull request
Oct 19, 2026
…C-546] (#816) * fix(inkless:consolidation): exclude consolidation from ConsumerLag [KC-546] ConsolidationFetcherThread inherits AbstractFetcherThread lag tracking, so its diskless-to-local backlog was registered under FetcherLagMetrics.ConsumerLag alongside classic replica lag. Dashboards and scrapers that sum that metric then treat consolidation backlog as replica catch-up. Skip only the ConsumerLag JMX gauge for consolidation fetchers while keeping in-memory fetcherLagStats for MaxLag. ConsolidationLocalLag remains the external first-hop lag signal. Test plan - :core:test AbstractFetcherThreadTest, ReplicaFetcherThreadTest, ConsolidationFetcherThreadTest - spotlessCheck; vale on the added prose Assisted-by: Composer * Refine comments in ConsolidationFetcherThread Updated comments for clarity and consistency. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConsolidationFetcherThread inherits AbstractFetcherThread lag tracking, so its diskless-to-local backlog was registered under FetcherLagMetrics.ConsumerLag alongside classic replica lag. Dashboards and scrapers that sum that metric then treat consolidation backlog as replica catch-up.
Skip only the ConsumerLag JMX gauge for consolidation fetchers while keeping in-memory fetcherLagStats for MaxLag. ConsolidationLocalLag remains the external first-hop lag signal.
Test plan
Assisted-by: Composer