Repository navigation
fix(inkless:retention): skip consolidating topics in WAL retention [KC-552] - #808
Merged
Merged
Conversation
viktorsomogyi
force-pushed
the
svv/KC-552-retention-guard
branch
3 times, most recently
from
September 23, 2026 09:30
2716767 to
1dfc140
Compare
viktorsomogyi
marked this pull request as ready for review
September 23, 2026 09:30
viktorsomogyi
force-pushed
the
svv/KC-552-retention-guard
branch
from
September 23, 2026 09:38
1dfc140 to
65114ee
Compare
…C-552] RetentionEnforcer deletes WAL batches from the control plane. On a topic this broker consolidates, that path ignores data RemoteLogManager still serves. The enforcer now skips those topics on each cycle when consolidation is enabled. ConsolidatedDisklessLogPruner still removes only remotely confirmed WAL data. ## Test plan - RetentionEnforcerTest covers a mixed ready set, consolidation disabled, and an all-consolidating ready set. - :core:testClasses compiles the ReplicaManager constructor wiring. Assisted-by: Grok 4.7 Co-authored-by: Cursor <cursoragent@cursor.com>
viktorsomogyi
force-pushed
the
svv/KC-552-retention-guard
branch
from
September 23, 2026 09:44
65114ee to
e489ab5
Compare
giuseppelillo
pushed a commit
that referenced
this pull request
Sep 24, 2026
…C-552] (#808) RetentionEnforcer deletes WAL batches from the control plane. On a topic this broker consolidates, that path ignores data RemoteLogManager still serves. The enforcer now skips those topics on each cycle when consolidation is enabled. ConsolidatedDisklessLogPruner still removes only remotely confirmed WAL data. ## Test plan - RetentionEnforcerTest covers a mixed ready set, consolidation disabled, and an all-consolidating ready set. - :core:testClasses compiles the ReplicaManager constructor wiring. Assisted-by: Grok 4.7 Co-authored-by: Cursor <cursoragent@cursor.com>
giuseppelillo
pushed a commit
that referenced
this pull request
Sep 24, 2026
…C-552] (#808) RetentionEnforcer deletes WAL batches from the control plane. On a topic this broker consolidates, that path ignores data RemoteLogManager still serves. The enforcer now skips those topics on each cycle when consolidation is enabled. ConsolidatedDisklessLogPruner still removes only remotely confirmed WAL data. ## Test plan - RetentionEnforcerTest covers a mixed ready set, consolidation disabled, and an all-consolidating ready set. - :core:testClasses compiles the ReplicaManager constructor wiring. Assisted-by: Grok 4.7 Co-authored-by: Cursor <cursoragent@cursor.com>
giuseppelillo
pushed a commit
that referenced
this pull request
Sep 24, 2026
…C-552] (#808) RetentionEnforcer deletes WAL batches from the control plane. On a topic this broker consolidates, that path ignores data RemoteLogManager still serves. The enforcer now skips those topics on each cycle when consolidation is enabled. ConsolidatedDisklessLogPruner still removes only remotely confirmed WAL data. ## Test plan - RetentionEnforcerTest covers a mixed ready set, consolidation disabled, and an all-consolidating ready set. - :core:testClasses compiles the ReplicaManager constructor wiring. Assisted-by: Grok 4.7 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RetentionEnforcer deletes WAL batches from the control plane. On a topic this broker consolidates, that path ignores data RemoteLogManager still serves. The enforcer now skips those topics on each cycle when consolidation is enabled. ConsolidatedDisklessLogPruner still removes only remotely confirmed WAL data.
Assisted-by: Grok 4.7
Co-authored-by: Cursor cursoragent@cursor.com