Repository navigation
fix(inkless:config): allow routine alters on diskless topics with remote.storage.enable=false - #804
Merged
Merged
Conversation
viktorsomogyi
force-pushed
the
svv/fix-tsu-config
branch
from
September 17, 2026 11:07
2fdebe8 to
f10dcdc
Compare
viktorsomogyi
marked this pull request as ready for review
September 17, 2026 11:08
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Deleting an enabled remote-storage override can bypass the consolidation invariant.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Allows routine configuration updates for legacy diskless topics with persisted remote.storage.enable=false.
Changes:
- Grandfathers unchanged diskless/remote-disabled configurations.
- Prioritizes the consolidation-specific validation error.
- Updates unit and integration expectations.
File summaries
| File | Description |
|---|---|
storage/.../LogConfig.java |
Refines transition validation. |
core/.../LogConfigTest.scala |
Expands transition tests. |
core/.../DisklessAndRemoteStorageConfigsTest.java |
Updates integration assertions. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ote.storage.enable=false The controller validates the merged topic config map, so an existing remote.storage.enable=false override looked like a disable on every alter. Reject only new diskless + remote=false transitions, and do that before mutual exclusion so the specific invariant still fires. Co-authored-by: Cursor <cursoragent@cursor.com>
viktorsomogyi
force-pushed
the
svv/fix-tsu-config
branch
from
September 23, 2026 14:18
2e71ee1 to
3d356ce
Compare
A deleted remote.storage.enable override disappears from the resulting config map. Resolve the target state from the combined config so incremental deletion and legacy omission cannot leave a diskless topic without remote storage. Co-authored-by: Cursor <cursoragent@cursor.com>
viktorsomogyi
force-pushed
the
svv/fix-tsu-config
branch
from
September 24, 2026 09:59
3d356ce to
79b0ca3
Compare
giuseppelillo
approved these changes
Sep 24, 2026
giuseppelillo
pushed a commit
that referenced
this pull request
Sep 24, 2026
…ote.storage.enable=false (#804) * fix(inkless:config): allow routine alters on diskless topics with remote.storage.enable=false The controller validates the merged topic config map, so an existing remote.storage.enable=false override looked like a disable on every alter. Reject only new diskless + remote=false transitions, and do that before mutual exclusion so the specific invariant still fires. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(inkless:config): reject remote storage override deletion A deleted remote.storage.enable override disappears from the resulting config map. Resolve the target state from the combined config so incremental deletion and legacy omission cannot leave a diskless topic without remote storage. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
giuseppelillo
pushed a commit
that referenced
this pull request
Sep 24, 2026
…ote.storage.enable=false (#804) * fix(inkless:config): allow routine alters on diskless topics with remote.storage.enable=false The controller validates the merged topic config map, so an existing remote.storage.enable=false override looked like a disable on every alter. Reject only new diskless + remote=false transitions, and do that before mutual exclusion so the specific invariant still fires. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(inkless:config): reject remote storage override deletion A deleted remote.storage.enable override disappears from the resulting config map. Resolve the target state from the combined config so incremental deletion and legacy omission cannot leave a diskless topic without remote storage. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
giuseppelillo
pushed a commit
that referenced
this pull request
Sep 24, 2026
…ote.storage.enable=false (#804) * fix(inkless:config): allow routine alters on diskless topics with remote.storage.enable=false The controller validates the merged topic config map, so an existing remote.storage.enable=false override looked like a disable on every alter. Reject only new diskless + remote=false transitions, and do that before mutual exclusion so the specific invariant still fires. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(inkless:config): reject remote storage override deletion A deleted remote.storage.enable override disappears from the resulting config map. Resolve the target state from the combined config so incremental deletion and legacy omission cannot leave a diskless topic without remote storage. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller validates the merged topic config map, so an existing remote.storage.enable=false override looked like a disable on every alter. Reject only new diskless + remote=false transitions, and do that before mutual exclusion so the specific invariant still fires.