Repository navigation
fix(inkless:ci): update Inkless CI workflow and JUnit catalog parsing - #788
Merged
Merged
Conversation
jeqo
force-pushed
the
jeqo/fix-junit-catalog-parameterized-names
branch
from
September 8, 2026 09:39
786ca0f to
d083b8a
Compare
Use checkout@v5, setup-java@v5, and the shared setup-python action so Inkless CI tracks the same pins as build.yml. Co-authored-by: Cursor <cursoragent@cursor.com>
Nobody consumed the Inkless CI test-catalog artifact, and the upload was gated on Java 21 so it never ran. Remove the step. Point the leftover annotation comments at Java 25 to match the test matrix. Co-authored-by: Cursor <cursoragent@cursor.com>
…junit.py Collate Test Catalog crashed on main after #772 because clean_test_name() required every JUnit display name to look like a Java method name. @ParameterizedTest(name = "{0}") names such as ObjectFetcherTest's '1 byte' are arbitrary strings; keep the cleaned name as a catalog key instead of failing the export. Export the catalog from Inkless CI so PRs targeting main hit the same path without waiting for Kafka CI on main. Co-authored-by: Cursor <cursoragent@cursor.com>
jeqo
force-pushed
the
jeqo/fix-junit-catalog-parameterized-names
branch
from
September 8, 2026 10:47
d083b8a to
7089c02
Compare
jeqo
marked this pull request as ready for review
September 8, 2026 12:06
tvainika
approved these changes
Sep 8, 2026
jeqo
added a commit
that referenced
this pull request
Sep 9, 2026
…#788) * chore(inkless:ci): bump Inkless CI action pins to match upstream Use checkout@v5, setup-java@v5, and the shared setup-python action so Inkless CI tracks the same pins as build.yml. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(inkless:ci): drop the dead Java 21 catalog archive Nobody consumed the Inkless CI test-catalog artifact, and the upload was gated on Java 21 so it never ran. Remove the step. Point the leftover annotation comments at Java 25 to match the test matrix. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(inkless:ci): tolerate non-identifier parameterized test names in junit.py Collate Test Catalog crashed on main after #772 because clean_test_name() required every JUnit display name to look like a Java method name. @ParameterizedTest(name = "{0}") names such as ObjectFetcherTest's '1 byte' are arbitrary strings; keep the cleaned name as a catalog key instead of failing the export. Export the catalog from Inkless CI so PRs targeting main hit the same path without waiting for Kafka CI on main. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
jeqo
added a commit
that referenced
this pull request
Sep 9, 2026
…#788) * chore(inkless:ci): bump Inkless CI action pins to match upstream Use checkout@v5, setup-java@v5, and the shared setup-python action so Inkless CI tracks the same pins as build.yml. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(inkless:ci): drop the dead Java 21 catalog archive Nobody consumed the Inkless CI test-catalog artifact, and the upload was gated on Java 21 so it never ran. Remove the step. Point the leftover annotation comments at Java 25 to match the test matrix. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(inkless:ci): tolerate non-identifier parameterized test names in junit.py Collate Test Catalog crashed on main after #772 because clean_test_name() required every JUnit display name to look like a Java method name. @ParameterizedTest(name = "{0}") names such as ObjectFetcherTest's '1 byte' are arbitrary strings; keep the cleaned name as a catalog key instead of failing the export. Export the catalog from Inkless CI so PRs targeting main hit the same path without waiting for Kafka CI on main. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
jeqo
added a commit
that referenced
this pull request
Sep 9, 2026
…#788) * chore(inkless:ci): bump Inkless CI action pins to match upstream Use checkout@v5, setup-java@v5, and the shared setup-python action so Inkless CI tracks the same pins as build.yml. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(inkless:ci): drop the dead Java 21 catalog archive Nobody consumed the Inkless CI test-catalog artifact, and the upload was gated on Java 21 so it never ran. Remove the step. Point the leftover annotation comments at Java 25 to match the test matrix. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(inkless:ci): tolerate non-identifier parameterized test names in junit.py Collate Test Catalog crashed on main after #772 because clean_test_name() required every JUnit display name to look like a Java method name. @ParameterizedTest(name = "{0}") names such as ObjectFetcherTest's '1 byte' are arbitrary strings; keep the cleaned name as a catalog key instead of failing the export. Export the catalog from Inkless CI so PRs targeting main hit the same path without waiting for Kafka CI on main. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collate Test Catalog on main crashed after #772:
clean_test_name()required every JUnit display name to look like a Java method name, and@ParameterizedTest(name = "{0}")names such as ObjectFetcherTest's1 byteare not. Inkless CI never hit that path — it parsed reports without--export-test-catalog— and its workflow pins had drifted frombuild.yml. See the commit messages for the reasoning behind each step.Commits
chore(inkless:ci): bump Inkless CI action pins to match upstreamchore(inkless:ci): drop the dead Java 21 catalog archivefix(inkless:ci): tolerate non-identifier parameterized test names in junit.pyTesting
Inkless CI now exports the catalog while parsing JUnit XML, so a display name like
1 bytefails on the PR instead of only on main Kafka collation.