Repository navigation
fix(inkless:release): run finalize-release on the workflow_call path - #729
Merged
Merged
Conversation
The finalize-release job (which creates the GitHub Release, attaches the .tgz binaries, and publishes the :<version> and :latest Docker images) was gated on `github.event_name == 'workflow_call'`. In a reusable workflow `github.event_name` reflects the caller's top-level event — which is `workflow_dispatch` when invoked from inkless-release.yml — so the condition was never true and the job was silently skipped. Every coordinated release created tags and images but no GitHub Release. Gate on `inputs.inkless_version` instead, which is set only on the workflow_call path and empty on the push-tag trigger, so finalize-release runs for coordinated releases and stays skipped on single-tag pushes.
giuseppelillo
enabled auto-merge (squash)
July 30, 2026 15:23
giuseppelillo
disabled auto-merge
July 30, 2026 15:25
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Inkless release automation by ensuring the finalize-release job runs when the publish workflow is invoked as a reusable workflow for coordinated releases, rather than being silently skipped due to an unreliable github.event_name value in reusable workflows.
Changes:
- Update the
finalize-releasejob gate to key offinputs.inkless_version(set only on theworkflow_callpath) instead ofgithub.event_name == 'workflow_call'. - Add inline documentation explaining why
github.event_nameis not a reliable discriminator for reusable workflow invocations and why the chosen signal is reliable.
jeqo
approved these changes
Jul 30, 2026
jeqo
pushed a commit
that referenced
this pull request
Aug 19, 2026
…729) The finalize-release job (which creates the GitHub Release, attaches the .tgz binaries, and publishes the :<version> and :latest Docker images) was gated on `github.event_name == 'workflow_call'`. In a reusable workflow `github.event_name` reflects the caller's top-level event — which is `workflow_dispatch` when invoked from inkless-release.yml — so the condition was never true and the job was silently skipped. Every coordinated release created tags and images but no GitHub Release. Gate on `inputs.inkless_version` instead, which is set only on the workflow_call path and empty on the push-tag trigger, so finalize-release runs for coordinated releases and stays skipped on single-tag pushes.
jeqo
pushed a commit
that referenced
this pull request
Aug 19, 2026
…729) The finalize-release job (which creates the GitHub Release, attaches the .tgz binaries, and publishes the :<version> and :latest Docker images) was gated on `github.event_name == 'workflow_call'`. In a reusable workflow `github.event_name` reflects the caller's top-level event — which is `workflow_dispatch` when invoked from inkless-release.yml — so the condition was never true and the job was silently skipped. Every coordinated release created tags and images but no GitHub Release. Gate on `inputs.inkless_version` instead, which is set only on the workflow_call path and empty on the push-tag trigger, so finalize-release runs for coordinated releases and stays skipped on single-tag pushes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The finalize-release job (which creates the GitHub Release, attaches the .tgz binaries, and publishes the : and :latest Docker images) was gated on
github.event_name == 'workflow_call'. In a reusable workflowgithub.event_namereflects the caller's top-level event — which isworkflow_dispatchwhen invoked from inkless-release.yml — so the condition was never true and the job was silently skipped. Every coordinated release created tags and images but no GitHub Release.Gate on
inputs.inkless_versioninstead, which is set only on the workflow_call path and empty on the push-tag trigger, so finalize-release runs for coordinated releases and stays skipped on single-tag pushes.