Repository navigation
pkgdb: discover libpq headers under the postgresql subdirectory - #50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third in the series after #49 (hdf5/mpi): another external whose dpkg discovery lands the header
outside the bare
$(dir)/include.Problem
On Debian/Ubuntu
libpq-devinstalls the client header at/usr/include/postgresql/libpq-fe.hand the library at
/usr/lib/<multiarch>/libpq.so._buildDpkgPackageDatabasehad nolibpqbranch, so it fell through to the generic
elseand emitted onlylibpq.dir, leavinglibpq.incpathat the default/usr/include. Building against libpq then fails withfatal error: 'libpq-fe.h' file not found.Fix
A
libpqemitter branch (same shape as hdf5/mpi): readdpkg -Lforlibpq-fe.handlibpq.soand emit
libpq.incpath/libpq.libpathvia_dpkgAnchor.Verification
In an
ubuntu:24.04container withlibpq-devinstalled,mm extern.libpq.infonow reportsincpath = /usr/include/postgresql,libpath = /usr/lib/aarch64-linux-gnu, and pyre'spyre-postgresbinding sources compile against a live postgresql-16 server (they failed on themissing header before).
The embedded clone in pyre's
packages/merlin/shells/MM.pygets the same fix in a companion pyre PR.Turned up while standing up a postgres server in the new pyre dev containers — a reminder the dpkg
sniffer wants a systematic per-package audit.