Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only. No code, no build rules, no behaviour. Every hunk in this branch starts at line 8
or earlier of its file.
why
Syncing
make/against pyre's embedded copy (share/mm/make/) turned up four files thatdiffered only in their preamble. Pyre had already been through a cleanup pass; the standalone
engine never was. Fixing those exposed a further defect present in both copies, and then a
broader one across
examples/.make:the engineFour files, restoring byte-identity with
pyre'sshare/mm/make/:compilers/gcc/gfortran.mm,compilers/intel/fortran.mm—mmichael.aivazis→michael.aivazisextern/libtorch/init.mm— copyright still read1998-2025extern/petsc/rules.mm— the author line had lost its emailThat last file then turned out to be non-conforming in both repositories: a stray
# parasimaffiliation line and a bare
#trailing the copyright, where the convention is a four-linepreamble followed by two blank lines. Corrected here and, identically, in
pyre/pyre#189.
make/and pyre'sshare/mm/make/now differ in exactly one file —mm/rules.mm, whose bannerdeliberately reads
merlin mmon the embedded side. The verbatim-copy invariant holds again.examples:the restThe same
# parasim+ trailing#shape turned out to be endemic toexamples/hello, and asweep of every tracked file surfaced a few more typos:
# parasimand the#trailing the copyright# -*- Python-*-— mode line missing its space# -*- coding : utf-8 -*-— stray space# -*- makefile -*-— lowercase, against 69Makefileelsewhere(c) 1998-2024what was deliberately left alone
mm(the driver) andexamples/simple/pkg/simple/meta.py.incarry# -*- python -*-inlowercase. Since the driver itself uses that form, it reads as a choice rather than a slip, so
neither was touched.
examples/step08/etc/bash/activate.bashand itsstep09twin have a#after the copyrighttoo, but there it separates the preamble from a descriptive comment block rather than trailing
it. An early pass stripped those; they were restored.
verification
make/diffed againstpyre'sshare/mm/make/: one file differs, the intentional banner.