8000 cosmetics: bring the preambles into conformance by aivazis · Pull Request #48 · aivazis/mm · GitHub
[go: up one dir, main page]

Skip to content

cosmetics: bring the preambles into conformance - #48

Merged
aivazis merged 2 commits into
mainfrom
preamble
Jul 9, 2026
Merged

aivazis merged 2 commits into
mainfrom
preamble

Conversation

@aivazis
@aivazis aivazis commented Jul 9, 2026
Copy link
Copy Markdown
Owner

Comment-only. No code, no build rules, no behaviour. Every hunk in this branch starts at line 8
or earlier of its file.

why

Syncing make/ against pyre's embedded copy (share/mm/make/) turned up four files that
differed only in their preamble. Pyre had already been through a cleanup pass; the standalone
engine never was. Fixing those exposed a further defect present in both copies, and then a
broader one across examples/.

make: the engine

Four files, restoring byte-identity with pyre's share/mm/make/:

  • compilers/gcc/gfortran.mm, compilers/intel/fortran.mm — mmichael.aivazis → michael.aivazis
  • extern/libtorch/init.mm — copyright still read 1998-2025
  • extern/petsc/rules.mm — the author line had lost its email

That last file then turned out to be non-conforming in both repositories: a stray # parasim
affiliation line and a bare # trailing the copyright, where the convention is a four-line
preamble followed by two blank lines. Corrected here and, identically, in
pyre/pyre#189.

make/ and pyre's share/mm/make/ now differ in exactly one file — mm/rules.mm, whose banner
deliberately reads merlin mm on the embedded side. The verbatim-copy invariant holds again.

examples: the rest

The same # parasim + trailing # shape turned out to be endemic to examples/hello, and a
sweep of every tracked file surfaced a few more typos:

defect files
stray # parasim and the # trailing the copyright 20
# -*- Python-*- — mode line missing its space 2
# -*- coding : utf-8 -*- — stray space 3
# -*- makefile -*- — lowercase, against 69 Makefile elsewhere 5
(c) 1998-2024 1

what was deliberately left alone

mm (the driver) and examples/simple/pkg/simple/meta.py.in carry # -*- python -*- in
lowercase. Since the driver itself uses that form, it reads as a choice rather than a slip, so
neither was touched.

examples/step08/etc/bash/activate.bash and its step09 twin have a # after the copyright
too, but there it separates the preamble from a descriptive comment block rather than trailing
it. An early pass stripped those; they were restored.

verification

  • Every hunk confirmed to start at line 8 or earlier — no file body was touched.
  • Re-scanned for all six defect classes afterwards: clean.
  • make/ diffed against pyre's share/mm/make/: one file differs, the intentional banner.

@aivazis
aivazis merged commit cb6c87c into main Jul 9, 2026
@aivazis
aivazis deleted the preamble branch July 9, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0